test(typescript-estree): enable more alignment tests #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
reviewed
Jan 21, 2019
packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts
Outdated
Show resolved
Hide resolved
armano2
reviewed
Jan 21, 2019
| * TODO: remove me in next babel > 7.2.3 | ||
| * Was expected to be fixed by PR into Babel: https://github.com/babel/babel/pull/9302 | ||
| * But not fixed in Babel 7.3 | ||
| * TODO: Investigate differences |
There was a problem hiding this comment.
in babel i implemented this in a little diffrent way.
we have one node TSImportType with property isTypeOf set to true/false (as is in ts)
in babel its 2 nodes: typeof -> TSImportType
spliting this node to 2 allows us to handle comments in between them typeof /* test */ import
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 94.83% 94.83%
=======================================
Files 48 48
Lines 2480 2480
Branches 381 381
=======================================
Hits 2352 2352
Misses 77 77
Partials 51 51
|
armano2
reviewed
Jan 21, 2019
| * TODO: remove me in next babel > 7.2.3 | ||
| * Was expected to be fixed by PR into Babel: https://github.com/babel/babel/pull/9284 | ||
| * But not fixed in Babel 7.3 | ||
| * TODO: Investigate differences |
There was a problem hiding this comment.
looks like we have issue with ranges, TSParameterProperty->AssignmentPattern
AssignmentPattern includes modifier into their range
but modifier is attached to TSParameterProperty
armano2
approved these changes
Jan 21, 2019
armanio123
pushed a commit
to armanio123/typescript-eslint
that referenced
this pull request
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.