Skip to content

fix(no-unsafe-assignment): add error message for unsafe object destructuring #11435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(no-unsafe-assignment): add error message for unsafe object destructuring #11435

wants to merge 1 commit into from
+12 −1,034

Conversation

divyanshudg-git
Copy link

Previously, object destructuring from an any-typed value used the wrong error message. This PR introduces a new unsafeObjectPattern message and applies it properly. Also includes a test case.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @divyanshudg-git!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 31, 2025 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit 19234e5
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/688b25ed62af980008157fc7

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 19234e5

Command Status Duration Result
nx run-many --target=build --parallel --exclude... ❌ Failed 15s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-31 08:16:41 UTC

@kirkwaiblinger
Copy link
Member

@divyanshudg-git

This PR and #11387 (comment) ignore our contributing guide and have some indicators of spam, so I'm closing this out.

If this is a misunderstanding, please let us know, and be sure to read and follow the contributing guide. Thanks!

@kirkwaiblinger kirkwaiblinger mentioned this pull request Jul 31, 2025
Open
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyanshudg-git @kirkwaiblinger