Skip to content

fix: tighten tsconfigRootDir validation #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

fix: tighten tsconfigRootDir validation #11463

wants to merge 31 commits into from
+233 −52

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Aug 6, 2025 •
edited
Loading

PR Checklist

Overview

This ensures that tsconfigRootDir must always be absolute if provided. Adds testing. Adjusts existing testing which used relative tsconfigRootDirs rather than absolute.

Handles normalization so that trailing path sep bug is also solved (test included)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 6, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7451eb5
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/689a6c6cecc3a200089eccf0
😎 Deploy Preview https://deploy-preview-11463--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 6, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7451eb5

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 21s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 2s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-11 22:25:07 UTC

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (fee2bc6) to head (7451eb5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pt-estree/src/parseSettings/createParseSettings.ts 93.54% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11463   +/-   ##
=======================================
  Coverage   90.87%   90.88%           
=======================================
  Files         505      505           
  Lines       51117    51142   +25     
  Branches     8415     8424    +9     
=======================================
+ Hits        46455    46480   +25     
  Misses       4648     4648           
  Partials       14       14
Flag Coverage Δ
unittest 90.88% <93.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ges/typescript-estree/src/create-program/shared.ts 88.75% <100.00%> (+0.94%) ⬆️
...pt-estree/src/parseSettings/createParseSettings.ts 92.69% <93.54%> (+0.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger mentioned this pull request Aug 6, 2025
Closed
4 tasks
@kirkwaiblinger kirkwaiblinger changed the title fix: tsconfigRootDir bugs fix: tighten tsconfigRootDir validation Aug 11, 2025
@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review August 11, 2025 22:27
bradzacher
bradzacher approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ilikeit

kirkwaiblinger
kirkwaiblinger commented Aug 11, 2025
View reviewed changes
packages/typescript-estree/src/parseSettings/createParseSettings.ts
Comment on lines +72 to +73
(process.platform === 'win32' &&
!/^[a-zA-Z]:/.test(userProvidedTsconfigRootDir))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tested but it doesn't get picked up in the coverage report, due to only being tested on windows. Tried to use an istanbul ignore comment, but vitest/esbuild/typescript has problems with coverage ignore comments due to comment stripping and I couldn't get it to work :(

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
2 participants
@kirkwaiblinger @bradzacher