typescript-eslint · JoshuaKGoldberg · Aug 18, 2025 · Aug 18, 2025
diff --git a/.../src/declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/1-TSESTree-AST.shot b/.../src/declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/1-TSESTree-AST.shot
diff --git a/...declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/5-AST-Alignment-AST.shot b/...declaration/TSEnumDeclaration/fixtures/with-member-one/snapshots/5-AST-Alignment-AST.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/fixture.ts b/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/fixture.ts
diff --git a/...pec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/1-TSESTree-Error.shot b/...pec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/1-TSESTree-Error.shot
diff --git a/...t-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/2-Babel-Error.shot b/...t-spec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/2-Babel-Error.shot
diff --git a/...ec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/3-Alignment-Error.shot b/...ec/src/element/TSEnumMember/fixtures/_error_/bigint-name/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/computed-string-name/fixture.ts b/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/computed-string-name/fixture.ts
diff --git a/...lement/TSEnumMember/fixtures/_error_/computed-string-name/snapshots/1-TSESTree-Error.shot b/...lement/TSEnumMember/fixtures/_error_/computed-string-name/snapshots/1-TSESTree-Error.shot
diff --git a/...c/element/TSEnumMember/fixtures/_error_/computed-string-name/snapshots/2-Babel-Error.shot b/...c/element/TSEnumMember/fixtures/_error_/computed-string-name/snapshots/2-Babel-Error.shot
diff --git a/...ement/TSEnumMember/fixtures/_error_/computed-string-name/snapshots/3-Alignment-Error.shot b/...ement/TSEnumMember/fixtures/_error_/computed-string-name/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/number-name/fixture.ts b/packages/ast-spec/src/element/TSEnumMember/fixtures/_error_/number-name/fixture.ts
diff --git a/...pec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/1-TSESTree-Error.shot b/...pec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/1-TSESTree-Error.shot
diff --git a/...t-spec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/2-Babel-Error.shot b/...t-spec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/2-Babel-Error.shot
diff --git a/...ec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/3-Alignment-Error.shot b/...ec/src/element/TSEnumMember/fixtures/_error_/number-name/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/element/TSEnumMember/spec.ts b/packages/ast-spec/src/element/TSEnumMember/spec.ts
@@ -1,15 +1,44 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
 import type { BaseNode } from '../../base/BaseNode';
-import type { Identifier } from '../../expression/Identifier/spec';
-import type { StringLiteral } from '../../expression/literal/StringLiteral/spec';
 import type { Expression } from '../../unions/Expression';
+import type {
+  PropertyNameComputed,
+  PropertyNameNonComputed,
+} from '../../unions/PropertyName';
 
-export interface TSEnumMember extends BaseNode {
+interface TSEnumMemberBase extends BaseNode {
   type: AST_NODE_TYPES.TSEnumMember;
-  id: Identifier | StringLiteral;
-  initializer: Expression | undefined;
-  /**
-   * @deprecated the enum member is always non-computed.
-   */
   computed: boolean;
+  id:
+    | PropertyNameComputed // this should only happen in semantically invalid code (ts error 1164)
+    | PropertyNameNonComputed;
+  initializer: Expression | undefined;
+}
+
+/**
+ * this should only really happen in semantically invalid code (errors 1164 and 2452)
+ *
+ * @example
+ * ```ts
+ * // VALID:
+ * enum Foo { ['a'] }
+ *
+ * // INVALID:
+ * const x = 'a';
+ * enum Foo { [x] }
+ * enum Bar { ['a' + 'b'] }
+ * ```
+ */
+export interface TSEnumMemberComputedName extends TSEnumMemberBase {
+  computed: true;
+  id: PropertyNameComputed;
 }
+
+export interface TSEnumMemberNonComputedName extends TSEnumMemberBase {
+  computed: false;
+  id: PropertyNameNonComputed;
+}
+
+export type TSEnumMember =
+  | TSEnumMemberComputedName
+  | TSEnumMemberNonComputedName;
diff --git a/...basics/fixtures/_error_/export-named-enum-computed-number/snapshots/1-TSESTree-Error.shot b/...basics/fixtures/_error_/export-named-enum-computed-number/snapshots/1-TSESTree-Error.shot
diff --git a/...asics/fixtures/_error_/export-named-enum-computed-number/snapshots/3-Alignment-Error.shot b/...asics/fixtures/_error_/export-named-enum-computed-number/snapshots/3-Alignment-Error.shot
diff --git a/...basics/fixtures/_error_/export-named-enum-computed-string/snapshots/1-TSESTree-Error.shot b/...basics/fixtures/_error_/export-named-enum-computed-string/snapshots/1-TSESTree-Error.shot
diff --git a/...asics/fixtures/_error_/export-named-enum-computed-string/snapshots/3-Alignment-Error.shot b/...asics/fixtures/_error_/export-named-enum-computed-string/snapshots/3-Alignment-Error.shot
diff --git a/...asics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/1-TSESTree-Error.shot b/...asics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/1-TSESTree-Error.shot
diff --git a/...sics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/3-Alignment-Error.shot b/...sics/fixtures/_error_/export-named-enum-computed-var-ref/snapshots/3-Alignment-Error.shot
diff --git a/...ges/ast-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/1-TSESTree-AST.shot b/...ges/ast-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/1-TSESTree-AST.shot
diff --git a/...st-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/5-AST-Alignment-AST.shot b/...st-spec/src/legacy-fixtures/basics/fixtures/const-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/...cy-fixtures/basics/fixtures/export-declare-const-named-enum/snapshots/1-TSESTree-AST.shot b/...cy-fixtures/basics/fixtures/export-declare-const-named-enum/snapshots/1-TSESTree-AST.shot
diff --git a/...xtures/basics/fixtures/export-declare-const-named-enum/snapshots/5-AST-Alignment-AST.shot b/...xtures/basics/fixtures/export-declare-const-named-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/...c/legacy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/1-TSESTree-AST.shot b/...c/legacy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/1-TSESTree-AST.shot
diff --git a/...acy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/5-AST-Alignment-AST.shot b/...acy-fixtures/basics/fixtures/export-declare-named-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/...-spec/src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/1-TSESTree-AST.shot b/...-spec/src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/1-TSESTree-AST.shot
diff --git a/.../src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/5-AST-Alignment-AST.shot b/.../src/legacy-fixtures/basics/fixtures/export-named-enum/snapshots/5-AST-Alignment-AST.shot
diff --git a/packages/ast-spec/src/legacy-fixtures/declare/fixtures/enum/snapshots/1-TSESTree-AST.shot b/packages/ast-spec/src/legacy-fixtures/declare/fixtures/enum/snapshots/1-TSESTree-AST.shot