Skip to content

feat(typescript-estree): forbid invalid keys in EnumMember #11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 1, 2025
Merged

feat(typescript-estree): forbid invalid keys in EnumMember #11497

merged 8 commits into from
Sep 1, 2025
+161 −234

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Aug 18, 2025 •
edited by kirkwaiblinger
Loading

This reverts commit 7648622.

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 18, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fb5506b
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68b581e16ead44000734965d
😎 Deploy Preview https://deploy-preview-11497--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit fb5506b

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 10s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run types:build ✅ Succeeded 10s View ↗
nx run generate-configs ✅ Succeeded 12s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-01 11:33:37 UTC

@fisker
Copy link
Contributor Author

fisker commented Aug 18, 2025

Looks like this is still an issue, #11232 (comment), any idea to fix it?

@fisker
Copy link
Contributor Author

fisker commented Aug 18, 2025

I'm not sure what I did, but CI passes now.

@fisker fisker marked this pull request as ready for review August 18, 2025 20:09
@codecov Codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 68.29268% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.84%. Comparing base (d7614a7) to head (fb5506b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 65.78% 13 Missing ⚠️

❌ Your patch status has failed because the patch coverage (68.29%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11497      +/-   ##
==========================================
- Coverage   90.87%   90.84%   -0.03%     
==========================================
  Files         505      505              
  Lines       51146    51167      +21     
  Branches     8424     8422       -2     
==========================================
+ Hits        46480    46485       +5     
- Misses       4652     4668      +16     
  Partials       14       14
Flag Coverage Δ
unittest 90.84% <68.29%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 97.79% <100.00%> (-0.02%) ⬇️
...ackages/scope-manager/src/referencer/Referencer.ts 97.93% <100.00%> (-0.01%) ⬇️
packages/typescript-estree/src/convert.ts 30.38% <65.78%> (+0.21%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisker fisker force-pushed the revert-11493-revert-11232 branch from fe02b99 to 2ac5502 Compare August 23, 2025 13:18
kirkwaiblinger
kirkwaiblinger reviewed Aug 27, 2025
View reviewed changes
packages/eslint-plugin/src/rules/naming-convention.ts Outdated
const id = node.id;
TSEnumMember: {
handler: (node: TSESTree.TSEnumMember, validator): void => {
// Unknown reason, can't get the correct type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the problem with these types is that this PR is missing a corresponding change in packages/types/src/ts-estree.ts.

See

typescript-eslint/packages/types/src/ts-estree.ts

Lines 197 to 202 in a0c30f2

interface TSEnumMemberComputedName {
parent: TSESTree.TSEnumBody;
}
interface TSEnumMemberNonComputedName {
parent: TSESTree.TSEnumBody;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed de0e9ff to clean them up 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 27, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 27, 2025
@kirkwaiblinger
Copy link
Member

kirkwaiblinger commented Aug 27, 2025 •
edited
Loading

Approving in that

Will give @bradzacher a chance to double-check in case before merging

@kirkwaiblinger kirkwaiblinger added AST PRs and Issues about the AST structure 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Aug 27, 2025
@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) September 1, 2025 05:28
@kirkwaiblinger kirkwaiblinger merged commit ee3efa7 into typescript-eslint:main Sep 1, 2025
61 checks passed
@fisker fisker deleted the revert-11493-revert-11232 branch September 1, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@bradzacher bradzacher Awaiting requested review from bradzacher

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge AST PRs and Issues about the AST structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: forbid invalid keys in EnumMember
2 participants
@fisker @kirkwaiblinger