-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(parser): handle optional chaining in scope analysis #1169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ecdb016
fix(parser): optional member expression
6209a43
test: added test for no-use-before-define
67dcf3c
Merge branch 'master' into master
Nizarius 27e84d9
style: added OptionalMemberExpression description
f51b448
feat: added tests and optional chaining expression to referencer
c7bc1d7
Merge branch 'master' into master
bradzacher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85 changes: 85 additions & 0 deletions
85
packages/eslint-plugin/tests/eslint-rules/no-use-before-define.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
import rule from 'eslint/lib/rules/no-use-before-define'; | ||
import { RuleTester } from '../RuleTester'; | ||
|
||
const ruleTester = new RuleTester({ | ||
parserOptions: { | ||
ecmaVersion: 6, | ||
sourceType: 'module', | ||
ecmaFeatures: {}, | ||
}, | ||
parser: '@typescript-eslint/parser', | ||
}); | ||
|
||
ruleTester.run('no-use-before-define', rule, { | ||
valid: [ | ||
` | ||
const updatedAt = data?.updatedAt; | ||
`, | ||
` | ||
function f() { | ||
return function t() {}; | ||
} | ||
f()?.(); | ||
`, | ||
` | ||
var a = { b: 5 }; | ||
alert(a?.b); | ||
`, | ||
], | ||
invalid: [ | ||
{ | ||
code: ` | ||
f(); | ||
function f() {} | ||
`, | ||
errors: [ | ||
{ | ||
message: "'f' was used before it was defined.", | ||
// the base rule doesn't use messageId | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
} as any, | ||
], | ||
}, | ||
{ | ||
code: ` | ||
alert(a); | ||
var a = 10; | ||
`, | ||
errors: [ | ||
{ | ||
message: "'a' was used before it was defined.", | ||
// the base rule doesn't use messageId | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
} as any, | ||
], | ||
}, | ||
{ | ||
code: ` | ||
f()?.(); | ||
function f() { | ||
return function t() {}; | ||
} | ||
`, | ||
errors: [ | ||
{ | ||
message: "'f' was used before it was defined.", | ||
// the base rule doesn't use messageId | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
} as any, | ||
], | ||
}, | ||
{ | ||
code: ` | ||
alert(a?.b); | ||
var a = { b: 5 }; | ||
`, | ||
errors: [ | ||
{ | ||
message: "'a' was used before it was defined.", | ||
// the base rule doesn't use messageId | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
} as any, | ||
], | ||
}, | ||
], | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.