Skip to content

feat(eslint-plugin): [member-ordering] add index signature #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2019
Merged

feat(eslint-plugin): [member-ordering] add index signature #1190

merged 2 commits into from
Dec 3, 2019

Conversation

sveyret
Copy link
Contributor

@sveyret sveyret commented Nov 10, 2019

Issue #1186 Add the index signature to ordering analysis.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sveyret!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@sveyret
feat(eslint-plugin - member-ordering): index signature
2e0e426 
Issue #1186 Add the index signature to ordering analysis.
@codecov
Copy link

codecov bot commented Nov 10, 2019 •
edited
Loading

Codecov Report

Merging #1190 into master will decrease coverage by 0.07%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
- Coverage   94.01%   93.93%   -0.08%     
==========================================
  Files         131      131              
  Lines        5797     5804       +7     
  Branches     1638     1639       +1     
==========================================
+ Hits         5450     5452       +2     
- Misses        186      188       +2     
- Partials      161      164       +3
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 92.3% <100%> (-5.03%) ⬇️
packages/eslint-plugin/src/util/misc.ts 86.2% <75%> (-1.8%) ⬇️

@sveyret
Copy link
Contributor Author

sveyret commented Nov 10, 2019

Coverage lowering is due to lines that should normally never be reached.

@bradzacher bradzacher changed the title feat(eslint-plugin - member-ordering): add index signature feat(eslint-plugin): [member-ordering] add index signature Nov 10, 2019
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 10, 2019
@sveyret
Copy link
Contributor Author

sveyret commented Nov 13, 2019

@bradzacher, is there still something I should do or shall I just wait for review?

@bradzacher
Copy link
Member

It's in the queue of PRs to review.
Sit tight, and we'll get around to it soon enough.

bradzacher
bradzacher approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this.

@bradzacher bradzacher merged commit b5a52a3 into typescript-eslint:master Dec 3, 2019
@sveyret sveyret deleted the member-ordering branch December 4, 2019 08:30
@armano2 armano2 mentioned this pull request Jan 1, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Closed
This was referenced Jan 24, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sveyret @bradzacher