Skip to content

fix(eslint-plugin): [camelcase] handle optional member expr #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2019
Merged

fix(eslint-plugin): [camelcase] handle optional member expr #1204

merged 2 commits into from
Nov 14, 2019

Conversation

a-tarasyuk
Copy link
Contributor

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 13, 2019 •
edited
Loading

Codecov Report

Merging #1204 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage    94.1%   94.14%   +0.04%     
==========================================
  Files         124      124              
  Lines        5325     5330       +5     
  Branches     1487     1489       +2     
==========================================
+ Hits         5011     5018       +7     
+ Misses        179      178       -1     
+ Partials      135      134       -1
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/camelcase.ts 90.9% <100%> (+8.76%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Nov 13, 2019
bradzacher
bradzacher requested changes Nov 13, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit - otherwise LGTM. Thanks for this

@a-tarasyuk a-tarasyuk force-pushed the bug/1196-camelcase-false-positive-with-optional-chaining branch from 41ea325 to 9d98baa Compare November 14, 2019 08:49
bradzacher
bradzacher approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): [camelcase] handle optional member expressions fix(eslint-plugin): [camelcase] handle optional member expr Nov 14, 2019
@bradzacher bradzacher merged commit 9c8203f into typescript-eslint:master Nov 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[camelcase] False positive with optional chaining
2 participants
@a-tarasyuk @bradzacher