Skip to content

chore: turn on prefer-nullish-coalescing locally #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2019
Merged

chore: turn on prefer-nullish-coalescing locally #1259

merged 2 commits into from
Nov 25, 2019

Conversation

bradzacher
Copy link
Member

and fix errors

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher force-pushed the turn-on-prefer-nullish-locally branch from a9a1433 to b66fb19 Compare November 25, 2019 18:13
@codecov
Copy link

codecov bot commented Nov 25, 2019 •
edited
Loading

Codecov Report

Merging #1259 into master will decrease coverage by 0.08%.
The diff coverage is 74.41%.

@@            Coverage Diff            @@
##           master   #1259      +/-   ##
=========================================
- Coverage   94.18%   94.1%   -0.09%     
=========================================
  Files         130     130              
  Lines        5679    5681       +2     
  Branches     1594    1596       +2     
=========================================
- Hits         5349    5346       -3     
  Misses        182     182              
- Partials      148     153       +5
Impacted Files Coverage Δ
packages/typescript-estree/src/simple-traverse.ts 95% <0%> (ø) ⬆️
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.39% <0%> (-1.08%) ⬇️
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 96.07% <0%> (ø) ⬆️
...eslint-plugin/src/rules/type-annotation-spacing.ts 95.34% <0%> (-2.33%) ⬇️
packages/eslint-plugin/src/rules/array-type.ts 93.33% <100%> (ø) ⬆️
...pt-estree/src/create-program/createWatchProgram.ts 92.3% <100%> (ø) ⬆️
...ages/eslint-plugin/src/rules/unified-signatures.ts 92.68% <100%> (ø) ⬆️
packages/eslint-plugin/src/util/types.ts 82.47% <100%> (ø) ⬆️
packages/parser/src/analyze-scope.ts 95.5% <100%> (ø) ⬆️
packages/eslint-plugin-tslint/src/rules/config.ts 100% <100%> (ø) ⬆️
... and 8 more

@bradzacher bradzacher merged commit 835378e into master Nov 25, 2019
@bradzacher bradzacher deleted the turn-on-prefer-nullish-locally branch November 25, 2019 19:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bradzacher