Skip to content

refactor(typescript-estree): simplify range calculation for body nodes #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 22, 2019

There is no changes to AST or ranges, its just plain optimization.

@armano2 armano2 requested a review from JamesHenry January 22, 2019 21:08
@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #127 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #127      +/-   ##
=========================================
- Coverage   95.14%   95.1%   -0.04%     
=========================================
  Files          49      49              
  Lines        2512    2494      -18     
  Branches      382     374       -8     
=========================================
- Hits         2390    2372      -18     
  Misses         73      73              
  Partials       49      49
Impacted Files Coverage Δ
packages/typescript-estree/src/node-utils.ts 96.05% <ø> (ø) ⬆️
packages/typescript-estree/src/convert.ts 94.48% <100%> (-0.13%) ⬇️

@armano2 armano2 changed the title refactor(typescript-estree): simplify range detection for class body refactor(typescript-estree): simplify range for class and interface body Jan 22, 2019
@armano2 armano2 changed the title refactor(typescript-estree): simplify range for class and interface body refactor(typescript-estree): simplify range calculation for body nodes Jan 22, 2019
@armano2 armano2 added enhancement New feature or request package: typescript-estree Issues related to @typescript-eslint/typescript-estree and removed package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Jan 22, 2019
@armano2 armano2 self-assigned this Jan 22, 2019
@JamesHenry JamesHenry merged commit 74802b1 into typescript-eslint:master Jan 22, 2019
@armano2 armano2 deleted the optimize branch January 22, 2019 23:31
armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull request Jan 24, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants