Skip to content

test(ts-estree): add test scenario for unix/windows/mac EOL #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test(ts-estree): add test scenario for unix/windows/mac EOL #129

wants to merge 1 commit into from

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 22, 2019

Right now we don't have alignment tests for template literals, but during sampling of code i found out that we have issues with cooked value, EOL is not preserved, and its always converted to LF,

this is not fix and it will not pass, i'm unsure if this should be done on our side or in tsc.

@armano2 armano2 added help wanted Extra attention is needed DO NOT MERGE PRs which should not be merged yet labels Jan 22, 2019
@armano2 armano2 closed this Jan 23, 2019
@armano2 armano2 deleted the line-endings-literals branch January 23, 2019 21:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO NOT MERGE PRs which should not be merged yet help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant