Skip to content

docs(eslint-plugin): typo in space-before-function-paren docs #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Dec 2, 2019
Merged

docs(eslint-plugin): typo in space-before-function-paren docs #1297

merged 1 commit into from Dec 2, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 2, 2019

This lint is about the space after function but in the example both versions do have one.
The eslint page has it like this

function withoutSpace(x) { // <-- NO space
    // ...
}

function withSpace (x) { // <-- space
    // ...
}

var anonymousWithoutSpace = function() {};

var anonymousWithSpace = function () {};

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @BO41!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

bradzacher
bradzacher approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@bradzacher bradzacher changed the title Remove space in space-before-function-paren docs(eslint-plugin): typo in space-before-function-paren docs Dec 2, 2019
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Dec 2, 2019
@bradzacher bradzacher merged commit 5362561 into typescript-eslint:master Dec 2, 2019
@ghost ghost deleted the patch-1 branch December 3, 2019 17:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bradzacher