Skip to content

chore(parser): mark TS as optional peer dependency #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

chore(parser): mark TS as optional peer dependency #1327

merged 1 commit into from
Dec 11, 2019

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented Dec 11, 2019

Since @typescript-eslint/typescript-estree has an optional peer dependency on TS, @typescript-eslint/parser should too.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @arcanis!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the title Adds TS as optional peer dependency chore(parser): mark TS as optional peer dependency Dec 11, 2019
bradzacher
bradzacher approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this.

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Dec 11, 2019
@bradzacher bradzacher merged commit 348d2f6 into typescript-eslint:master Dec 11, 2019
@arcanis arcanis mentioned this pull request Dec 13, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcanis @bradzacher