feat: add internal eslint plugin for repo-specific lint rules #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1373 +/- ##
==========================================
- Coverage 94.09% 94.04% -0.05%
==========================================
Files 133 139 +6
Lines 5940 5975 +35
Branches 1685 1691 +6
==========================================
+ Hits 5589 5619 +30
- Misses 187 192 +5
Partials 164 164
|
armano2
previously requested changes
Dec 23, 2019
packages/eslint-plugin-internal/src/rules/no-typescript-default-import.ts
Outdated
Show resolved
Hide resolved
…t-import.ts Co-Authored-By: Armano <armano2@users.noreply.github.com>
armano2
approved these changes
Dec 24, 2019
This was referenced Jan 12, 2020
Closed
This was referenced Feb 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few things I want to enforce internally.
Save us from having to communicate these things in PR reviews.
import ts from 'typescript'in packages.allowSyntheticDefaultImportsimport {} from '@typescript-eslint/typescript-estree'from the plugins, where the package isn't a dependency.Adding this in now reduces the barrier to entry, meaning we can easily add rules to warn against patterns we see people do in the future.