chore: migrate build from azure-pipelines to actions #1383

armano2 · 2019-12-26T06:58:29Z

This is POC of build migration from azure-pipelines to actions

From my research about github actions:

higher concurrent job count (20)
we can setup tasks/jobs for releases to npm and github packages from within github
actions allow us to automate tagging/closing stale tickets, and setup automatic responses
for branch in same repository as PR, it runs action only once for branch and shares it with PR
in case of error in matrix step (by default) its stops all other steps from matrix, e.g.
https://github.com/armano2/node-markdown-spellcheck/runs/364664300
other big projects that migrated to actions:
- typescript: https://github.com/microsoft/TypeScript/actions
- eslint: https://github.com/eslint/eslint/actions
- prettier: https://github.com/prettier/prettier/actions
- babel: https://github.com/babel/babel/actions
- jest: https://github.com/facebook/jest/actions
- vscode: https://github.com/microsoft/vscode/actions
- node: https://github.com/nodejs/node/actions

Examples

External project test

PR: https://github.com/armano2/node-markdown-spellcheck/pull/3

bradzacher

@JamesHenry was the one that set up all of the azure stuff. Would like his eyeball.

Also do you know how easy it is to setup actions for things like locking old, closed issues? I get annoyed when people necro old things, but have been too lazy to investigate a bot 😅

Also we have the typescript-eslint bot which posts on PRs whenever they are opened - would that be easy to migrate?

.github/workflows/ci.yml

armano2 · 2019-12-26T13:17:13Z

Also do you know how easy it is to setup actions for things like locking old, closed issues? I get annoyed when people necro old things, but have been too lazy to investigate a bot 😅

yea i could set this up to, but this can be done in separate PR

about our bot, there few actions that are already prepeared for this for example:
https://github.com/marketplace/actions/first-interaction or https://github.com/marketplace/actions/close-stale-issues

name: Greetings

on: [pull_request, issues]

jobs:
  greeting:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/first-interaction@v1
      with:
        repo-token: ${{ secrets.GITHUB_TOKEN }}
        issue-message: 'Message that will be displayed on users'' first issue'
        pr-message: 'Message that will be displayed on users'' first pr'

JamesHenry · 2019-12-26T15:53:07Z

Err...why? 😅 also we have a slack channel precisely to discuss things like this

armano2 · 2019-12-30T16:42:21Z

@JamesHenry i added small description

bradzacher · 2019-12-31T00:17:24Z

one good reason to move to github actions is because it centralises the admin, which makes it a bit more transparent.
Otherwise I see it as "the same as azure pipelines".

Same for the bots, having them as actions would be a win for transparent and easy maintaining (eg I don't know where or how the PR message bot is implemented atm).

codecov · 2020-01-28T21:28:16Z

Codecov Report

Merging #1383 into master will increase coverage by 0.3%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1383     +/-   ##
=========================================
+ Coverage   95.19%   95.49%   +0.3%     
=========================================
  Files         148      150      +2     
  Lines        6967     6639    -328     
  Branches     2007     1880    -127     
=========================================
- Hits         6632     6340    -292     
+ Misses        124      112     -12     
+ Partials      211      187     -24

Impacted Files	Coverage Δ
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts	`0% <0%> (-100%)`	⬇️
...s/eslint-plugin/src/rules/interface-name-prefix.ts	`83.33% <0%> (-16.67%)`	⬇️
...-plugin/src/rules/no-unnecessary-type-assertion.ts	`90.12% <0%> (-6.85%)`	⬇️
packages/eslint-plugin/src/rules/unbound-method.ts	`94.44% <0%> (-2.23%)`	⬇️
...ackages/eslint-plugin/src/rules/no-implied-eval.ts	`95.91% <0%> (-1.91%)`	⬇️
packages/eslint-plugin/src/rules/typedef.ts	`95.91% <0%> (-1.35%)`	⬇️
...plugin/src/rules/explicit-module-boundary-types.ts	`85.45% <0%> (-0.76%)`	⬇️
...-plugin/src/rules/explicit-member-accessibility.ts	`96.36% <0%> (-0.74%)`	⬇️
...ackages/eslint-plugin/src/rules/member-ordering.ts	`92.3% <0%> (-0.38%)`	⬇️
...nt-plugin/src/rules/no-unused-vars-experimental.ts	`91.39% <0%> (-0.1%)`	⬇️
... and 41 more

bradzacher

I think this is a good idea. I'm happy to merge this as a trial at the very least.
We can run both azure and github actions for a period whilst we make a greater decision

bradzacher · 2020-02-12T02:09:17Z

.github/workflows/ci.yml

+  primary_code_validation_and_tests:
+    name: Primary code validation and tests
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 12
+        uses: actions/setup-node@v1
+        with:
+          node-version: 12
+
+      # This also runs a build as part of the postinstall bootstrap
+      - name: install and build
+        run: |
+          yarn --ignore-engines --frozen-lockfile
+          yarn check-clean-workspace-after-install
+
+      # Note that this command *also* typechecks tests/tools,
+      # whereas the build only checks src files
+      - name: Typecheck all packages
+        run: yarn typecheck
+
+      - name: Check code formatting
+        run: yarn format-check
+
+      - name: Run linting
+        run: yarn lint
+
+      - name: Validate spelling
+        run: yarn check:spelling
+
+      - name: Run unit tests
+        run: yarn test
+        env:
+          CI: true
+
+      - name: Run integrations tests
+        run: yarn integration-tests
+        env:
+          CI: true
+
+      - name: Publish code coverage report
+        uses: codecov/codecov-action@v1
+        with:
+          yml: ./codecov.yml
+          token: ${{ secrets.CODECOV_TOKEN }}
+          flags: unittest
+          name: codecov


Question - did we want to split all of this up to give us more granular status checks?
I know that a bit of a pain point for people is just seeing "primary validation" failed, and then having to dig into the logs to see which step failed.

I.e. one job for each of:

type check

format check

lint

spelling

test + integration (+ coverage publish) test on latest node

you actually don't have to as actions are showing it in overview screen

example: https://github.com/armano2/test-eslint-monorpo/actions/runs/36409848

you can click on Check failure on line 1 in packages/a/src/index.js if file was modified it's going to show annotation within this file

armano2 · 2020-02-12T02:56:17Z

as for codecov/codecov-action we should wait for codecov/codecov-action#53 to get merged first as it has same issue with PR ids as pipelines

for now we could just disable it or use bash uploader

armano2 added DO NOT MERGE PRs which should not be merged yet RFC labels Dec 26, 2019

This comment has been minimized.

Sign in to view

armano2 requested a review from a team December 26, 2019 07:00

bradzacher requested a review from JamesHenry December 26, 2019 11:53

bradzacher reviewed Dec 26, 2019

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

armano2 marked this pull request as ready for review January 2, 2020 02:53

armano2 self-assigned this Jan 12, 2020

armano2 added 15 commits January 28, 2020 22:11

chore: migrate build from azure-pipelines to actions

20d7bc8

chore: filter out branches

42f88f2

Create ci.yml

4cadfcb

fix: correct typo in name of folder

fe9df4e

fix: correct typo

e791217

test: add changes requested in code review

d05a1ac

fix: do not run build on push on other branches than master

e45fb61

fix: correct syntax

025c2c1

fix: let pull_requests to be run on all branches

4efeba4

chore: update ci to match azure

5cf09e9

chore: upgrade actions/checkout and add yarn cache

a2f8435

chore: add missing CI env variable for unit tests

bb20596

test: disable cache and enable --runInBand

d5f807f

test: apply new changes to CI config

204aae6

chore: update shields

b89e4d1

bradzacher reviewed Feb 12, 2020

View reviewed changes

Merge branch 'master' into github-actions-test

11d7c7b

JamesHenry merged commit c969884 into typescript-eslint:master Mar 16, 2020

github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020

armano2 deleted the github-actions-test branch January 12, 2021 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate build from azure-pipelines to actions #1383

chore: migrate build from azure-pipelines to actions #1383

armano2 commented Dec 26, 2019 •

edited

Loading

This comment has been minimized.

bradzacher left a comment

armano2 commented Dec 26, 2019 •

edited

Loading

JamesHenry commented Dec 26, 2019

armano2 commented Dec 30, 2019

bradzacher commented Dec 31, 2019 •

edited

Loading

codecov bot commented Jan 28, 2020 •

edited

Loading

bradzacher left a comment

bradzacher Feb 12, 2020

armano2 Feb 12, 2020 •

edited

Loading

armano2 commented Feb 12, 2020 •

edited

Loading

chore: migrate build from azure-pipelines to actions #1383

chore: migrate build from azure-pipelines to actions #1383

Conversation

armano2 commented Dec 26, 2019 • edited Loading

Examples

External project test

This comment has been minimized.

bradzacher left a comment

Choose a reason for hiding this comment

armano2 commented Dec 26, 2019 • edited Loading

JamesHenry commented Dec 26, 2019

armano2 commented Dec 30, 2019

bradzacher commented Dec 31, 2019 • edited Loading

codecov bot commented Jan 28, 2020 • edited Loading

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment

bradzacher Feb 12, 2020

Choose a reason for hiding this comment

armano2 Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

armano2 commented Feb 12, 2020 • edited Loading

armano2 commented Dec 26, 2019 •

edited

Loading

armano2 commented Dec 26, 2019 •

edited

Loading

bradzacher commented Dec 31, 2019 •

edited

Loading

codecov bot commented Jan 28, 2020 •

edited

Loading

armano2 Feb 12, 2020 •

edited

Loading

armano2 commented Feb 12, 2020 •

edited

Loading