Skip to content

feat(eslint-plugin): [strict-bool-expr] add allowSafe option #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 31, 2019
Merged

feat(eslint-plugin): [strict-bool-expr] add allowSafe option #1385

merged 4 commits into from
Dec 31, 2019

Conversation

Rajin9601
Copy link
Contributor

Fixes #1025

allowSafe allows non-falsey types (i.e. non string / number / boolean) to be used as boolean expressions.

This option allows user to safely check null & undefined without having to explicitly write obj == null when used with allowNullable.

// as-is
const str = obj == null && obj.foo == null && obj.foo.bar

// to-be
const str = obj && obj.foo && obj.foo.bar

Note that setting allowNullable & allowSafe to true allows boolean | null as a boolean expression, which is not safe.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Rajin9601!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Dec 28, 2019
@Rajin9601 Rajin9601 requested a review from armano2 December 30, 2019 04:00
armano2
armano2 approved these changes Dec 30, 2019
View reviewed changes
Copy link
Collaborator

@armano2 armano2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 31, 2019
bradzacher
bradzacher approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 31, 2019
@bradzacher bradzacher changed the title feat(eslint-plugin): add allowSafe option to strict-boolean-expressions feat(eslint-plugin): [strict-bool-expr] add allowSafe option Dec 31, 2019
@bradzacher bradzacher merged commit 9344233 into typescript-eslint:master Dec 31, 2019
This was referenced Jan 15, 2020
Open
Open
Open
Open
This was referenced Feb 8, 2020
Closed
Closed
This was referenced Feb 26, 2020
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
3 participants
@Rajin9601 @armano2 @bradzacher