test(eslint-plugin): add missing test cases for rules #1402

armano2 · 2020-01-03T02:37:04Z

This PR adds some edge cases for uncovered syntax that is actually validated by rules.

each commit represents changes to tests for one rule

there is few minor changes to code (redundant conditions)

i was unable to get coverage for all rules that i checked up to 100% (some of code paths can't be triggered)

affected tests for rules:

array-type
no-empty-interface
prefer-for-of
no-type-alias
triple-slash-reference
no-unnecessary-type-assertion
class-name-casing
no-misused-new
no-throw-literal
explicit-member-accessibility

valid test cases for TSImportEqualsDeclaration

packages/eslint-plugin/src/rules/no-empty-interface.ts

packages/eslint-plugin/tests/rules/triple-slash-reference.test.ts

packages/eslint-plugin/tests/rules/no-type-alias.test.ts

packages/eslint-plugin/tests/rules/class-name-casing.test.ts

…sibility

bradzacher

lgtm - thanks for this

codecov · 2020-01-05T21:24:46Z

Codecov Report

Merging #1402 into master will increase coverage by 0.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   94.05%   94.43%   +0.37%     
==========================================
  Files         140      140              
  Lines        6037     6034       -3     
  Branches     1713     1712       -1     
==========================================
+ Hits         5678     5698      +20     
+ Misses        193      186       -7     
+ Partials      166      150      -16

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-array-constructor.ts	`100% <ø> (ø)`	⬆️
packages/eslint-plugin/src/rules/no-type-alias.ts	`100% <ø> (+4.91%)`	⬆️
...-plugin/src/rules/explicit-member-accessibility.ts	`96.36% <ø> (+7.27%)`	⬆️
packages/eslint-plugin/src/rules/no-misused-new.ts	`100% <ø> (+8.69%)`	⬆️
...kages/eslint-plugin/src/rules/class-name-casing.ts	`100% <ø> (+12%)`	⬆️
...-plugin/src/rules/no-unnecessary-type-assertion.ts	`89.87% <100%> (+2.53%)`	⬆️
...ages/eslint-plugin/src/rules/no-empty-interface.ts	`100% <100%> (+13.33%)`	⬆️
packages/eslint-plugin/src/rules/array-type.ts	`95.23% <0%> (+1.9%)`	⬆️
...ckages/eslint-plugin/src/rules/no-throw-literal.ts	`95.55% <0%> (+2.22%)`	⬆️
... and 6 more

bradzacher

sorry, I didn't realise github only showed me the last commit when I opened the notification...
A few suggestions, otherwise LGTM

packages/eslint-plugin/tests/fixtures/class.ts

packages/eslint-plugin/tests/rules/no-misused-new.test.ts

packages/eslint-plugin/tests/rules/no-throw-literal.test.ts

bradzacher

LGTM thanks!

armano2 added 3 commits January 3, 2020 03:28

test(eslint-plugin): add edge case test for array-type rule

bf49641

chore(eslint-plugin): remove redundant conditions in no-empty-interface

016f7d8

test(eslint-plugin): add missing test case for prefer-for-of

cb87f8e

This comment has been minimized.

Sign in to view

armano2 added 3 commits January 3, 2020 19:31

test(eslint-plugin): add missing test case for no-type-alias

00c8a62

test(eslint-plugin): test cases for triple-slash-reference

f78ed75

valid test cases for TSImportEqualsDeclaration

test(eslint-plugin): test cases for no-unnecessary-type-assertion

5f14900

armano2 added the tests anything to do with testing label Jan 3, 2020

armano2 self-assigned this Jan 3, 2020

refactor(eslint-plugin): class-name-casing cleanup & tests

fe5e6d9