typescript-eslint · bradzacher · Jan 5, 2020 · Jan 3, 2020 · Jan 3, 2020 · Jan 3, 2020
diff --git a/packages/eslint-plugin/src/rules/class-name-casing.ts b/packages/eslint-plugin/src/rules/class-name-casing.ts
@@ -67,7 +67,13 @@ export default util.createRule<Options, MessageIds>({
      * @param decl The declaration
      * @param id The name of the declaration
      */
-    function report(decl: TSESTree.Node, id: TSESTree.Identifier): void {
+    function report(
+      decl:
+        | TSESTree.ClassDeclaration
+        | TSESTree.TSInterfaceDeclaration
+        | TSESTree.ClassExpression,
+      id: TSESTree.Identifier,
+    ): void {
       let friendlyName;
 
       switch (decl.type) {
@@ -78,8 +84,6 @@ export default util.createRule<Options, MessageIds>({
         case AST_NODE_TYPES.TSInterfaceDeclaration:
           friendlyName = 'Interface';
           break;
-        default:
-          friendlyName = decl.type;
       }
 
       context.report({

diff --git a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts
@@ -183,7 +183,7 @@ export default util.createRule<Options, MessageIds>({
 
     /**
      * Checks that the parameter property has the desired accessibility modifiers set.
-     * @param {TSESTree.TSParameterProperty} node The node representing a Parameter Property
+     * @param node The node representing a Parameter Property
      */
     function checkParameterPropertyAccessibilityModifier(
       node: TSESTree.TSParameterProperty,

diff --git a/packages/eslint-plugin/src/rules/no-array-constructor.ts b/packages/eslint-plugin/src/rules/no-array-constructor.ts
@@ -15,7 +15,7 @@ export default util.createRule({
     },
     fixable: 'code',
     messages: {
-      useLiteral: 'The array literal notation [] is preferrable.',
+      useLiteral: 'The array literal notation [] is preferable.',
     },
     schema: [],
   },

diff --git a/packages/eslint-plugin/src/rules/no-empty-interface.ts b/packages/eslint-plugin/src/rules/no-empty-interface.ts
@@ -49,33 +49,25 @@ export default util.createRule<Options, MessageIds>({
           return;
         }
 
-        if (!node.extends || node.extends.length === 0) {
+        const extend = node.extends;
+        if (!extend || extend.length === 0) {
           context.report({
             node: node.id,
             messageId: 'noEmpty',
           });
-        } else if (node.extends.length === 1) {
+        } else if (extend.length === 1) {
           // interface extends exactly 1 interface --> Report depending on rule setting
-          if (allowSingleExtends) {
-            return;
-          } else {
+          if (!allowSingleExtends) {
             context.report({
               node: node.id,
               messageId: 'noEmptyWithSuper',
-              fix(fixer) {
-                if (node.extends && node.extends.length) {
-                  return [
-                    fixer.replaceText(
-                      node,
-                      `type ${sourceCode.getText(
-                        node.id,
-                      )} = ${sourceCode.getText(node.extends[0])}`,
-                    ),
-                  ];
-                }
-
-                return null;
-              },
+              fix: fixer =>
+                fixer.replaceText(
+                  node,
+                  `type ${sourceCode.getText(node.id)} = ${sourceCode.getText(
+                    extend[0],
+                  )}`,
+                ),
             });
           }
         }

diff --git a/packages/eslint-plugin/src/rules/no-misused-new.ts b/packages/eslint-plugin/src/rules/no-misused-new.ts
@@ -22,7 +22,7 @@ export default util.createRule({
   defaultOptions: [],
   create(context) {
     /**
-     * @param {ASTNode} node type to be inspected.
+     * @param node type to be inspected.
      * @returns name of simple type or null
      */
     function getTypeReferenceName(
@@ -48,8 +48,8 @@ export default util.createRule({
     }
 
     /**
-     * @param {ASTNode} parent parent node.
-     * @param {ASTNode} returnType type to be compared
+     * @param parent parent node.
+     * @param returnType type to be compared
      */
     function isMatchingParentType(
       parent: undefined | TSESTree.Node,

diff --git a/packages/eslint-plugin/src/rules/no-type-alias.ts b/packages/eslint-plugin/src/rules/no-type-alias.ts
@@ -218,8 +218,7 @@ export default util.createRule<Options, MessageIds>({
 
     /**
      * Validates the node looking for aliases, callbacks and literals.
-     * @param node the node to be validated.
-     * @param compositionType the type of composition this alias is part of (null if not
+     * @param type the type of composition this alias is part of (null if not
      *                                  part of a composition)
      * @param isTopLevel a flag indicating this is the top level node.
      */

diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts
@@ -245,7 +245,7 @@ export default util.createRule<Options, MessageIds>({
         node: TSESTree.TSTypeAssertion | TSESTree.TSAsExpression,
       ): void {
         if (
-          options?.typesToIgnore?.includes(
+          options.typesToIgnore?.includes(
             sourceCode.getText(node.typeAnnotation),
           )
         ) {

diff --git a/packages/eslint-plugin/tests/fixtures/class.ts b/packages/eslint-plugin/tests/fixtures/class.ts
@@ -0,0 +1,2 @@
+// used by no-throw-literal test case to validate custom error
+export class Error {}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// used by no-throw-literal test case to validate custom error
		export class Error {}
armano2 marked this conversation as resolved. Show resolved Hide resolved