fix(typescript-estree): fix persisted parse for relative paths #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
armano2
commented
Jan 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
==========================================
- Coverage 94.45% 94.45% -0.01%
==========================================
Files 142 142
Lines 6082 6081 -1
Branches 1727 1727
==========================================
- Hits 5745 5744 -1
Misses 183 183
Partials 154 154
|
armano2
commented
Jan 11, 2020
| @@ -11,6 +11,7 @@ import { createSourceFile } from './create-program/createSourceFile'; | |||
| import { Extra, TSESTreeOptions, ParserServices } from './parser-options'; | |||
| import { getFirstSemanticOrSyntacticError } from './semantic-or-syntactic-errors'; | |||
| import { TSESTree } from './ts-estree'; | |||
| import { ensureAbsolutePath } from './create-program/shared'; | |||
There was a problem hiding this comment.
i don't like this, maybe i should move it somewhere else
- this issue is specific to vscode
armano2
commented
Jan 11, 2020
| cb(current!, ts.FileWatcherEventKind.Changed); | ||
| }); | ||
| hasCallback = true; | ||
| break; |
There was a problem hiding this comment.
removal of his line fixes issue with vscode, but i'm unable to test this
armano2
added a commit
that referenced
this pull request
Jan 11, 2020
this should be fixed when #1424 gets merged
bradzacher
approved these changes
Jan 12, 2020
This was referenced Feb 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1303 seams to be related to resolution of relative paths in watch part of persisted parse.
its possible that this is different unrelated issue
Tasks:
find if its related to Newly created Vue SFC File: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser #1303: its notfixes #1303