Skip to content

chore: migrate lodash from function packages #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2020
Merged

chore: migrate lodash from function packages #1430

merged 1 commit into from
Jan 12, 2020

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 11, 2020

This PR migrates our usages of lodash.* standalone per method packages to single module.

Why?
Other projects started moving out of standalone per method packages in favor of single module (eg. babel)

However, use of these packages is discouraged and they will be removed in v5.
https://lodash.com/per-method-packages

fixes #1399

@typescript-eslint

This comment has been minimized.

@armano2 armano2 self-assigned this Jan 11, 2020
@armano2 armano2 added the dependencies Issue about dependencies of the package label Jan 11, 2020
@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #1430 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         142      142           
  Lines        6077     6077           
  Branches     1726     1726           
=======================================
  Hits         5742     5742           
  Misses        182      182           
  Partials      153      153
Impacted Files Coverage Δ
packages/eslint-plugin-tslint/src/rules/config.ts 100% <100%> (ø) ⬆️
packages/typescript-estree/src/node-utils.ts 96.98% <100%> (ø) ⬆️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'm okay with this!

@bradzacher bradzacher merged commit c69e402 into typescript-eslint:master Jan 12, 2020
@armano2 armano2 deleted the lodash-migrate branch January 12, 2020 22:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lodash is deprecating per method packages
2 participants