test: one snapshot per fixture test #1491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
what's the runtime like?
|
|
in my local env difference is +-10sec, and i did change this only for estree (as POC) |
Conflicts: packages/typescript-estree/tests/lib/__snapshots__/javascript.ts.snap packages/typescript-estree/tests/lib/__snapshots__/jsx.ts.snap packages/typescript-estree/tests/lib/__snapshots__/typescript.ts.snap
|
CI is complaining about path that i used |
|
Surprising that it's so much faster. It must be because it circumvents the checks to clean up the snapshot afterward. |
|
i played yesterday a little with this plugin and it seems that i can make it work with jest update (it requires small modification to this plugin) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative approach to ticket #1142 and change proposed in #1152
Main difference is that this code does not require generation of additional files (test per file) but extends jest functionality by allowing us to provide path to generated snapshot
Changes:
In test files i added one property (path): https://github.com/typescript-eslint/typescript-eslint/pull/1491/files#diff-8b3fe597033edf9c839ecff70500df9e
In test utils from ts-estree i added small piece of code to split snapshots:
e4722e8#diff-c976a68babc2637f35c7d6074d995843R41-R47