Skip to content

fix(parser): add visiting of type parameters in JSXOpeningElement #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2019
Merged

fix(parser): add visiting of type parameters in JSXOpeningElement #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18ffb9b
fix(parser): add visiting of type parameters in JSXOpeningElement
armano2 Jan 27, 2019
5cf002c
fix(parser): name and attributes is always present in JSXOpeningElement
armano2 Jan 27, 2019
61b0e17
test(eslint-plugin): add test case for no-unused-vars
armano2 Jan 27, 2019
a05c124
Merge branch 'master' into visitor-keys
JamesHenry Jan 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/eslint-plugin/tests/lib/rules/no-unused-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,20 @@ export interface Bar extends foo.i18n {}
import foo from 'foo';
import bar from 'foo';
export interface Bar extends foo.i18n<bar> {}
`
`,
// https://github.com/typescript-eslint/typescript-eslint/issues/141
{
filename: 'test.tsx',
code: `
import { TypeA } from './interface';
export const a = <GenericComponent<TypeA> />;
`,
parserOptions: {
ecmaFeatures: {
jsx: true
}
}
}
],

invalid: [
Expand Down
9 changes: 9 additions & 0 deletions packages/parser/src/analyze-scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ class Referencer extends OriginalReferencer {
}
}

/**
* Override.
*/
JSXOpeningElement(node: any) {
this.visit(node.name);
this.visitTypeParameters(node);
this.visit(node.attributes);
}

/**
* Override.
* Don't create the reference object in the type mode.
Expand Down
7 changes: 7 additions & 0 deletions packages/parser/src/visitor-keys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import eslintVisitorKeys from 'eslint-visitor-keys';

export const visitorKeys = eslintVisitorKeys.unionWith({
// Additional estree nodes.
Import: [],
// Additional Properties.
ArrayPattern: ['elements', 'typeAnnotation'],
ArrowFunctionExpression: ['typeParameters', 'params', 'returnType', 'body'],
Expand Down Expand Up @@ -30,6 +32,11 @@ export const visitorKeys = eslintVisitorKeys.unionWith({
RestElement: ['argument', 'typeAnnotation'],
NewExpression: ['callee', 'typeParameters', 'arguments'],
CallExpression: ['callee', 'typeParameters', 'arguments'],
// JSX
JSXOpeningElement: ['name', 'typeParameters', 'attributes'],
JSXClosingFragment: [],
JSXOpeningFragment: [],
JSXSpreadChild: ['expression'],

// Additional Nodes.
BigIntLiteral: [],
Expand Down
1 change: 1 addition & 0 deletions packages/parser/tests/fixtures/scope-analysis/import-keyword.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import('test');
1 change: 1 addition & 0 deletions packages/parser/tests/fixtures/scope-analysis/typed-jsx-element.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
const a = <GenericComponent<TypeA> />;
Loading