Skip to content

fix(typescript-estree): persisted parse and module none #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2020
Merged

fix(typescript-estree): persisted parse and module none #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d17462
fix(typescript-estree): add test cases for module none
armano2 Jan 24, 2020
bec1fbb
fix(typescript-estree): update tests to include all module types
armano2 Jan 25, 2020
15a48cd
fix(typescript-estree): apply fix for issue
armano2 Jan 25, 2020
a7f11d0
chore(typescript-estree): update comments
armano2 Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/typescript-estree/src/create-program/createDefaultProgram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ function createDefaultProgram(
return undefined;
}

const compilerHost = ts.createCompilerHost(commandLine.options, true);
const compilerHost = ts.createCompilerHost(
commandLine.options,
/* setParentNodes */ true,
);
const oldReadFile = compilerHost.readFile;
compilerHost.readFile = (fileName: string): string | undefined =>
path.normalize(fileName) === path.normalize(extra.filePath)
Expand Down
2 changes: 1 addition & 1 deletion packages/typescript-estree/src/create-program/createIsolatedProgram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function createIsolatedProgram(code: string, extra: Extra): ASTAndProgram {
filename,
code,
ts.ScriptTarget.Latest,
true,
/* setParentNodes */ true,
getScriptKind(extra, filename),
);
},
Expand Down
2 changes: 2 additions & 0 deletions packages/typescript-estree/src/create-program/createWatchProgram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ function getProgramsForProjects(

// cache watch program and return current program
knownWatchProgramMap.set(tsconfigPath, programWatch);
// sets parent pointers in source files
program.getTypeChecker();
results.push(program);
}

Expand Down
34 changes: 34 additions & 0 deletions packages/typescript-estree/tests/lib/persistentParse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ const CONTENTS = {
bar: 'console.log("bar")',
'baz/bar': 'console.log("baz bar")',
'bat/baz/bar': 'console.log("bat/baz/bar")',
number: 'const foo = 1;',
object: '(() => { })();',
string: 'let a: "a" | "b";',
};

const cwdCopy = process.cwd();
Expand Down Expand Up @@ -304,4 +307,35 @@ describe('persistent parse', () => {

baseTests(tsConfigExcludeBar, tsConfigIncludeAll);
});

describe('tsconfig with module set', () => {
const moduleTypes = [
'None',
'CommonJS',
'AMD',
'System',
'UMD',
'ES6',
'ES2015',
'ESNext',
];

for (const module of moduleTypes) {
describe(`module ${module}`, () => {
const tsConfigIncludeAll = {
compilerOptions: { module },
include: ['./**/*'],
};

const testNames = ['object', 'number', 'string', 'foo'] as const;
for (const name of testNames) {
it(`first parse of ${name} should not throw`, () => {
const PROJECT_DIR = setup(tsConfigIncludeAll);
writeFile(PROJECT_DIR, name);
expect(() => parseFile(name, PROJECT_DIR)).not.toThrow();
});
}
});
}
});
});