Skip to content

feat(eslint-plugin): support negative matches for filter #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2020
Merged

feat(eslint-plugin): support negative matches for filter #1517

merged 5 commits into from
Jan 30, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 25, 2020

Fixes #1512

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@G-Rath G-Rath requested a review from bradzacher January 25, 2020 05:02
@codecov
Copy link

codecov bot commented Jan 25, 2020 •
edited
Loading

Codecov Report

Merging #1517 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
+ Coverage   95.41%   95.41%   +<.01%     
==========================================
  Files         139      139              
  Lines        6384     6386       +2     
  Branches     1831     1832       +1     
==========================================
+ Hits         6091     6093       +2     
  Misses        108      108              
  Partials      185      185
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 88.51% <100%> (+0.06%) ⬆️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jan 25, 2020
bradzacher
bradzacher requested changes Jan 30, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the test on line 83, there's a really ugly negative lookahead regex.
Could you please convert this into a new negative matcher?

Some v minor comments. Otherwise LGTM.
Thanks for doing this!

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jan 30, 2020
@G-Rath G-Rath requested a review from bradzacher January 30, 2020 04:36
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 30, 2020
bradzacher
bradzacher approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@bradzacher bradzacher merged commit b24fbe8 into typescript-eslint:master Jan 30, 2020
@G-Rath G-Rath deleted the support-negative-matches-for-filter branch January 31, 2020 01:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[naming-convention] Support negative matches for filter option
2 participants
@G-Rath @bradzacher