feat(eslint-plugin): add new rule no-for-in-array #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
reviewed
Jan 28, 2019
|
@armano2 How would I test line 38 in the rule? It's not a case that would ever really get hit if |
|
hmm, in most cases nodes are present, and i think you should remove this if. we have cases of nodes not from TS, and "broken" parts of code like |
armano2
suggested changes
Jan 28, 2019
armano2
reviewed
Jan 28, 2019
bradzacher
reviewed
Jan 30, 2019
j-f1
previously requested changes
Jan 30, 2019
|
@uniqueiniquity I think the confusion over the .md formatting has been resolved now, things should be easier once this is brought up to date with master Thanks! |
JamesHenry
approved these changes
Feb 6, 2019
bradzacher
approved these changes
Feb 7, 2019
armano2
approved these changes
Feb 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 96.75% 96.76% +0.01%
==========================================
Files 52 53 +1
Lines 2462 2472 +10
Branches 370 370
==========================================
+ Hits 2382 2392 +10
Misses 40 40
Partials 40 40
|
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding equivalent of TSLint's
no-for-in-array.