Skip to content

feat(eslint-plugin): [require-await] add --fix support #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

feat(eslint-plugin): [require-await] add --fix support #1561

merged 1 commit into from
Feb 20, 2020

Conversation

nevir
Copy link
Contributor

@nevir nevir commented Feb 2, 2020 •
edited
Loading

This adds --fix support for the require-await rule.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nevir!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement New feature or request label Feb 3, 2020
@codecov
Copy link

codecov bot commented Feb 9, 2020 •
edited
Loading

Codecov Report

Merging #1561 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
- Coverage   95.55%   95.52%   -0.03%     
==========================================
  Files         142      142              
  Lines        6596     6621      +25     
  Branches     1887     1895       +8     
==========================================
+ Hits         6303     6325      +22     
  Misses        106      106              
- Partials      187      190       +3

bradzacher
bradzacher requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, mostly LGTM.

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Feb 19, 2020
nevir
nevir commented Feb 20, 2020
View reviewed changes
Copy link
Contributor Author

@nevir nevir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review 👍 updated

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Feb 20, 2020
@nevir
Copy link
Contributor Author

nevir commented Feb 20, 2020

Oh, ASI, how I love you ><

bradzacher
bradzacher approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding this!

@bradzacher bradzacher merged commit 9edd863 into typescript-eslint:master Feb 20, 2020
@nevir
Copy link
Contributor Author

nevir commented Feb 20, 2020

Awesome, thanks!

@nevir nevir deleted the nevir/return-await-autofix branch February 20, 2020 17:24
@yangmingshan
Copy link

But this PR is add --fix support for the return-await rule, not require-await. Release log is also wrong.

This was referenced Mar 9, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nevir @yangmingshan @bradzacher