-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs(eslint-plugin): update link to deprecation rule in roadmap #1611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @gund! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
@@ -112,7 +112,7 @@ It lists all TSLint rules along side rules from the ESLint ecosystem that are th | |||
| TSLint rule | | ESLint rule | | |||
| ---------------------------- | :-: | -------------------------------------------------- | | |||
| [`cyclomatic-complexity`] | 🌟 | [`complexity`][complexity] | | |||
| [`deprecation`] | 🌓 | [`import/no-deprecated`] <sup>[1]</sup> | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to add this link to the bottom section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it does not apply anymore, since the rule applies not only to imports but to all deprecated references just like the original tslint rule...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the link to the bottom section so that this line renders as a link
Bottom section:
https://github.com/gund/typescript-eslint/blob/patch-1/packages/eslint-plugin/ROADMAP.md#L677-L688
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, will update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This resolves #1223 and updates link to deprecation plugin rule.