WIP: feat(eslint-plugin): [consistent-type-assertion] add allowAsReturn option
#1628
Conversation
|
Thanks for the PR, @mbrowne! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
| objectLiteralTypeAssertions?: 'allow' | 'allow-as-parameter' | 'never'; | ||
| allowAsReturn?: boolean; |
There was a problem hiding this comment.
this shouldn't be a separate boolean flag.
It would be better to accept an array of strings, i.e.:
type Options =
| {
assertionStyle: 'as' | 'angle-bracket';
objectLiteralTypeAssertions?:
| 'allow'
| 'allow-as-parameter'
| 'allow-as-return'
| 'never'
| ('allow-as-parameter' | 'allow-as-return')[];
}
| {
assertionStyle: 'never';
}|
note for next time - if you've got a WIP PR, you should open it as a draft PR in github. |
|
Closed in favor of #1651 |
This PR adds an option to
consistent-type-assertionto allow type assertions as part of a return statement (but otherwise preferringconst x: Tformat).I'm not sure of the best way to add this new option while preserving backward compatibility. Once one of the maintainers points me in the right direction, I can adjust and complete this PR.
For more details, see this issue:
#1629
(Resolves #1629)