-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): add rule no-unsafe-return #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
05df893
to
745b7b3
Compare
47ba6e8
to
296b0e7
Compare
745b7b3
to
7e385ad
Compare
296b0e7
to
15bbd95
Compare
15bbd95
to
0402a87
Compare
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
==========================================
- Coverage 95.37% 95.36% -0.02%
==========================================
Files 146 147 +1
Lines 6836 6904 +68
Branches 1964 1984 +20
==========================================
+ Hits 6520 6584 +64
- Misses 111 112 +1
- Partials 205 208 +3
|
0402a87
to
e8d922a
Compare
See #791
I think it's better to introduce these as a number of separate rules.
It makes it easier for people to opt in to the rules, and keeps each implementation small and focused.
This also makes it easier and faster to build and release, as we can build and release smaller rules instead of releasing one monolithic rule.
Based off of #1643
This rule does two things:
any
.function foo(): Set<string> { return new Set<any>([1]) }