feat(eslint-plugin): add rule no-unsafe-call #1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
cbf1242 to
ee060d9
Compare
ecbf587 to
4f10ca3
Compare
47ba6e8 to
296b0e7
Compare
202dca3 to
8fbc865
Compare
0402a87 to
e8d922a
Compare
8fbc865 to
7cd15e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1647 +/- ##
=======================================
Coverage 95.36% 95.37%
=======================================
Files 147 148 +1
Lines 6904 6916 +12
Branches 1985 1988 +3
=======================================
+ Hits 6584 6596 +12
Misses 112 112
Partials 208 208
|
This was referenced Mar 12, 2020
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #791
I think it's better to introduce these as a number of separate rules.
It makes it easier for people to opt in to the rules, and keeps each implementation small and focused.
This also makes it easier and faster to build and release, as we can build and release smaller rules instead of releasing one monolithic rule.
Based off of #1644
This rule simply checks all call/new expressions, and makes sure that you're not calling/constructing an
anytype.