feat(eslint-plugin): [no-unnecessary-condition] report when non-nullish is compared to null
/undefined
#1659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Fixes #1591 .
This is a pretty minimal "handles exactly the case raised in the issue" fix. While looking into this on the issue tracker, I also found Typescript#32627 which is another case that TS won't catch. Might be worth trying to "beef up" this logic to handle this more generally.