feat(eslint-plugin): [no-unnecessary-condition] report when non-nullish is compared to null/undefined
#1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @Retsam! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
bradzacher
reviewed
Mar 3, 2020
4a24c42 to
ccd6777
Compare
Codecov Report
@@ Coverage Diff @@
## v3 #1659 +/- ##
==========================================
- Coverage 93.66% 93.63% -0.03%
==========================================
Files 169 169
Lines 7653 7667 +14
Branches 2187 2190 +3
==========================================
+ Hits 7168 7179 +11
- Misses 228 229 +1
- Partials 257 259 +2
|
=== undefinednull/undefined
bradzacher
pushed a commit
that referenced
this pull request
May 11, 2020
…sh is compared to `null`/`undefined` (#1659)
bradzacher
pushed a commit
that referenced
this pull request
May 14, 2020
…sh is compared to `null`/`undefined` (#1659)
bradzacher
pushed a commit
that referenced
this pull request
May 17, 2020
…sh is compared to `null`/`undefined` (#1659)
bradzacher
pushed a commit
that referenced
this pull request
May 21, 2020
…sh is compared to `null`/`undefined` (#1659)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Fixes #1591 .
This is a pretty minimal "handles exactly the case raised in the issue" fix. While looking into this on the issue tracker, I also found Typescript#32627 which is another case that TS won't catch. Might be worth trying to "beef up" this logic to handle this more generally.