feat(eslint-plugin): add extension rule lines-between-class-members
#1684
Conversation
|
Thanks for the PR, @yeonjuan! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 93.93% 93.93% -0.01%
==========================================
Files 171 172 +1
Lines 7816 7829 +13
Branches 2243 2245 +2
==========================================
+ Hits 7342 7354 +12
Misses 217 217
- Partials 257 258 +1
|
There was a problem hiding this comment.
Thanks for doing this!
Haven't reviewed the code yet, but just some quick feedback on the docs.
Example of how we like to do extension rule docs now a days - instead of copy-pasting the ESLint docs, just list the changes we're adding to the rule, and link out to the ESLint docs.
That way we don't have to worry as much about getting out of date.
I.e. in this case, you can just list the new option and how it works, and that covers it.
|
@bradzacher |
# Conflicts: # packages/eslint-plugin/README.md # packages/eslint-plugin/src/configs/all.json # packages/eslint-plugin/typings/eslint-rules.d.ts
lines-between-class-members
Fixes #1610