Skip to content

feat(eslint-plugin): add rule prefer-ts-expect-error #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2020
Merged

feat(eslint-plugin): add rule prefer-ts-expect-error #1705

merged 3 commits into from
Apr 13, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Mar 8, 2020

I think this should be included in the recommended, as I can't think of a case where // @ts-expect-error can't replace // @ts-ignore, but that might get tricky since TS3.9 & ESLint 7 are a few months apart 😬

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added enhancement: plugin rule option New rule option for an existing eslint-plugin rule enhancement: new plugin rule New rule request for eslint-plugin and removed enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Mar 9, 2020
bradzacher
bradzacher previously approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@codecov
Copy link

codecov bot commented Apr 12, 2020 •
edited
Loading

Codecov Report

Merging #1705 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   94.48%   94.39%   -0.10%     
==========================================
  Files         162      164       +2     
  Lines        7494     7583      +89     
  Branches     2151     2179      +28     
==========================================
+ Hits         7081     7158      +77     
- Misses        178      182       +4     
- Partials      235      243       +8
Flag Coverage Δ
#unittest 94.39% <100.00%> (-0.10%) ⬇️
Impacted Files Coverage Δ
.../eslint-plugin/src/rules/prefer-ts-expect-error.ts 100.00% <100.00%> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts 82.60% <0.00%> (-3.60%) ⬇️
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-for-in-array.ts 100.00% <0.00%> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 95.00% <0.00%> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts 100.00% <0.00%> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/restrict-template-expressions.ts 100.00% <0.00%> (ø)
... and 2 more

@bradzacher bradzacher changed the title feat(eslint-plugin): create prefer-ts-expect-error rule feat(eslint-plugin): create rule prefer-ts-expect-error Apr 12, 2020
@bradzacher bradzacher added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge awaiting response Issues waiting for a reply from the OP or another party labels Apr 12, 2020
@bradzacher
Copy link
Member

There's been a few linting changes since this was last merged - once those are resolved, this is good to merge

@bradzacher bradzacher removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Apr 12, 2020
@G-Rath
Copy link
Contributor Author

G-Rath commented Apr 12, 2020 •
edited
Loading

There's been a few linting changes

I noticed a few new internal rules - I'm a big fan of the ones around applying prettier to all tests, and the aligning of multiline tests. Might have to pinch those from you 😉

@bradzacher
Copy link
Member

I should probably put that rule somewhere more accessible - I'm sure there's a few people that wouldn't mind it. It took me a few hours to write it!

@G-Rath G-Rath requested a review from bradzacher April 13, 2020 00:57
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 13, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): create rule prefer-ts-expect-error feat(eslint-plugin): add rule prefer-ts-expect-error Apr 13, 2020
@bradzacher bradzacher merged commit 7021f21 into typescript-eslint:master Apr 13, 2020
@G-Rath G-Rath deleted the create-prefer-ts-expect-error-rule branch April 13, 2020 02:54
This was referenced Apr 19, 2020
Merged
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G-Rath @bradzacher