feat(eslint-plugin): [explicit-function-return-type] add option to allow concise arrows that start with void #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @G-Rath! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1732 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 162 162
Lines 7487 7494 +7
Branches 2146 2150 +4
=======================================
+ Hits 7074 7081 +7
Misses 178 178
Partials 235 235
|
bradzacher
requested changes
Apr 12, 2020
bradzacher
approved these changes
Apr 13, 2020
This was referenced Apr 19, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an option to complement the
no-voidbase rule allowing the use ofvoidin the same conditions.Since that issue is still being evaluated, I've not made any reference to it, but the use-case is still valid even if the team decide against it.
The idea is to not require you to double up
void:This change means that an option can be enabled that allows you to drop the
voidreturn type:This is only allowed when the option is enabled and: the arrow function is concise, and starts with the
voidoperator.I'm completely open to bikeshedding on the name & such - I just didn't feel it was worth an issue given how small it is to implement, and makes more sense seeing it visually.