Skip to content

fix(eslint-plugin): [no-unnec-type-assertion] allow const assertions #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 18, 2020
Merged

fix(eslint-plugin): [no-unnec-type-assertion] allow const assertions #1741

merged 3 commits into from
Mar 18, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1734

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@a-tarasyuk a-tarasyuk closed this Mar 16, 2020
@a-tarasyuk a-tarasyuk reopened this Mar 16, 2020
@a-tarasyuk
Copy link
Contributor Author

@bradzacher It seems that CI doesn't work :(.

@bradzacher bradzacher added the enhancement New feature or request label Mar 16, 2020
@bradzacher
Copy link
Member

hmm. I saw this on another PR but I wasn't sure if it was the PR or what.
It looks like they're just not getting triggered... I'll take a look

@a-tarasyuk
Copy link
Contributor Author

@bradzacher thanks

@codecov
Copy link

codecov bot commented Mar 17, 2020 •
edited
Loading

Codecov Report

Merging #1741 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1741   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         148      148           
  Lines        6968     6971    +3     
  Branches     2009     2010    +1     
=======================================
+ Hits         6633     6636    +3     
  Misses        124      124           
  Partials      211      211
Flag Coverage Δ
#unittest 95.19% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.10% <100.00%> (+0.13%) ⬆️

bradzacher
bradzacher approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for this

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-unnec-type-assertion] allow const assertions fix(eslint-plugin): [no-unnec-type-assertion] allow const assertions Mar 17, 2020
@bradzacher bradzacher added bug Something isn't working 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed enhancement New feature or request labels Mar 17, 2020
@bradzacher bradzacher merged commit f76a1b3 into typescript-eslint:master Mar 18, 2020
This was referenced Mar 26, 2020
Merged
Merged
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-type-assertion] support const assertions
3 participants
@a-tarasyuk @bradzacher @existentialism