Skip to content

docs: title wording in root readme #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2020
Merged

docs: title wording in root readme #1787

merged 3 commits into from
Mar 23, 2020

Conversation

DanKaplanSES
Copy link
Contributor

See #552 (comment) for context

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tieTYT!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

bradzacher
bradzacher reviewed Mar 23, 2020
View reviewed changes
README.md
@@ -32,7 +32,7 @@
- [Contributors](#contributors)
- [Contributing Guide](#contributing-guide)

## Getting Started
## Getting Started / Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note - have to update the TOC as well, or else it won't link here.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Mar 23, 2020
@bradzacher bradzacher changed the title Add / Installation to the readme docs: wording in root readme Mar 23, 2020
@bradzacher bradzacher changed the title docs: wording in root readme docs: title wording in root readme Mar 23, 2020
bradzacher
bradzacher approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #1787 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         159      159           
  Lines        7112     7112           
  Branches     2033     2033           
=======================================
  Hits         6758     6758           
  Misses        154      154           
  Partials      200      200
Flag Coverage Δ
#unittest 95.02% <ø> (ø)

@bradzacher bradzacher merged commit 258fdd0 into typescript-eslint:master Mar 23, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanKaplanSES @bradzacher