Skip to content

fix(eslint-plugin): [no-explicit-any] error with ignoreRestArgs option #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 26, 2020
Merged

fix(eslint-plugin): [no-explicit-any] error with ignoreRestArgs option #1796

merged 6 commits into from
Mar 26, 2020

Conversation

doniyor2109
Copy link
Contributor

Fixes #1795

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @doniyor2109!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #1796 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1796      +/-   ##
==========================================
- Coverage   95.02%   94.99%   -0.03%     
==========================================
  Files         159      159              
  Lines        7112     7112              
  Branches     2033     2033              
==========================================
- Hits         6758     6756       -2     
  Misses        154      154              
- Partials      200      202       +2
Flag Coverage Δ
#unittest 94.99% <0.00%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 92.85% <0.00%> (-7.15%) ⬇️

@bradzacher bradzacher added the bug Something isn't working label Mar 25, 2020
bradzacher
bradzacher requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit - otherwise lgtm, thanks

bradzacher
bradzacher approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): check node against nil fix(eslint-plugin): [no-explicit-any] error with ignoreRestArgs option Mar 26, 2020
@bradzacher bradzacher merged commit 638d84d into typescript-eslint:master Mar 26, 2020
This was referenced Apr 2, 2020
Merged
Merged
This was referenced Apr 9, 2020
Merged
Merged
This was referenced Apr 21, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/no-explicit-any] Error when specifying ignoreRestArgs option
2 participants
@doniyor2109 @bradzacher