chore: separate linting checks to their own step #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
If linting/formatting/spelling fails, it should not block running the tests. If they do block, they can increase the iteration time for contributors, because they will have to fix them before they can see the status of their tests. By not blocking, a contributor will be able to submit a PR, and come back ~5min later knowing they will be able to see if their code passes linting _and_ tests. This should also knock ~40-60s off of the perceived runtime, as it parallelises some of the work.
155df34 to
c43fc00
Compare
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 159 159
Lines 7112 7112
Branches 2033 2033
=======================================
Hits 6758 6758
Misses 154 154
Partials 200 200
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If linting/formatting/spelling fails, it should not block running the tests.
If they do block, they can increase the iteration time for contributors, because they will have to fix them before they can see the status of their tests.
By not blocking, a contributor will be able to submit a PR, and come back ~5min later knowing they will be able to see if their code passes linting and tests.
This should also knock ~40-60s off of the perceived runtime, as it parallelises some of the work.