Skip to content

docs(eslint-plugin): add missing invalid-void link to ROADMAP.md #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

docs(eslint-plugin): add missing invalid-void link to ROADMAP.md #1816

merged 2 commits into from
Mar 30, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

Oops 😬

Screenshot showing it incorrectly formatted as a raw link

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Mar 28, 2020
Closed
2 tasks
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Mar 30, 2020
@bradzacher bradzacher changed the title Added missing invalid-void link to ROADMAP.md docs(eslint-plugin): add missing invalid-void link to ROADMAP.md Mar 30, 2020
bradzacher
bradzacher approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #1816 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         159      159           
  Lines        7114     7114           
  Branches     2035     2035           
=======================================
  Hits         6756     6756           
  Misses        155      155           
  Partials      203      203
Flag Coverage Δ
#unittest 94.96% <ø> (ø)

@bradzacher bradzacher merged commit 543bc79 into typescript-eslint:master Mar 30, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the patch-1 branch March 30, 2020 11:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher