-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: turn on plugin-test-formatting rule #1822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
91ecd4b
to
8a4396c
Compare
020c4cd
to
d140f77
Compare
a6fcb8d
to
51d563a
Compare
a38d090
to
05edf30
Compare
Codecov Report
@@ Coverage Diff @@
## master #1822 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 160 160
Lines 7263 7263
Branches 2081 2081
=======================================
Hits 6874 6874
Misses 167 167
Partials 222 222
|
05edf30
to
ce63ed2
Compare
ce63ed2
to
dfb97cd
Compare
@@ -5,14 +5,16 @@ const ruleTester = new RuleTester({ | |||
parser: '@typescript-eslint/parser', | |||
}); | |||
|
|||
ruleTester.run('ts-ignore', rule, { | |||
ruleTester.run('ban-ts-comment', rule, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was called ts-ignore
because it's testing only ts-ignore
s. That's why the other runs are ts-check
, ts-nocheck
etc
(Also no idea why I used backticks for these valids - I noticed this while doing invalid-void
and facepalmed).
Went through every test and fixed the output.
Took forever, but now that it's done it's done.
NOTE - built on top of #1821