Skip to content

fix(eslint-plugin): fix no-base-to-string boolean literal check #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 27, 2020
Merged

fix(eslint-plugin): fix no-base-to-string boolean literal check #1850

merged 6 commits into from
Apr 27, 2020

Conversation

duduluu
Copy link
Contributor

@duduluu duduluu commented Apr 4, 2020 •
edited
Loading

Fixes #1655
Feat: add option ignoreTypeNames

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @duduluu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 4, 2020 •
edited
Loading

Codecov Report

Merging #1850 into master will increase coverage by 0.00%.
The diff coverage is 95.45%.

@@           Coverage Diff           @@
##           master    #1850   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files         166      168    +2     
  Lines        7608     7651   +43     
  Branches     2185     2199   +14     
=======================================
+ Hits         7179     7220   +41     
  Misses        183      183           
- Partials      246      248    +2
Flag Coverage Δ
#unittest 94.36% <95.45%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...nt-plugin/src/rules/consistent-type-definitions.ts 90.32% <ø> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 88.51% <ø> (ø)
...es/eslint-plugin/src/rules/no-floating-promises.ts 100.00% <ø> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 77.14% <ø> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.16% <ø> (ø)
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 80.00% <ø> (ø)
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <ø> (ø)
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <ø> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 95.00% <ø> (ø)
...nt-plugin/src/rules/no-untyped-public-signature.ts 100.00% <ø> (ø)
... and 13 more

@bradzacher bradzacher added the bug Something isn't working label Apr 4, 2020
@astorije
Copy link
Contributor

astorije commented Apr 8, 2020

@duduluu, thanks for this! With regards to @felixfbecker's comment at #1655 (comment), do you want to support other types here?

Selfishly I'm hitting this issue with RegExps, so that would be helpful :)

> /myRegExp/.toString()
'/myRegExp/'

@bradzacher
Copy link
Member

just RegExp will do, the other two should already pass the checks as they have toString

bradzacher
bradzacher requested changes Apr 8, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rc as per request to also support RegExp

@duduluu
Copy link
Contributor Author

duduluu commented Apr 18, 2020

Sorry for late, let me try.

@duduluu
Copy link
Contributor Author

duduluu commented Apr 18, 2020

Hi, @bradzacher . Does that mean this PR is unnecessary after the TypeScript merges your fixes for base types' definition?

@felixfbecker
Copy link

No, because there can be people on older TypeScript versions :)

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 18, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 25, 2020
bradzacher
bradzacher requested changes Apr 26, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on change to set the default to be "what it should be".
otherwise, LGTM. thanks

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 26, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 27, 2020
bradzacher
bradzacher approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 2f45e99 into typescript-eslint:master Apr 27, 2020
This was referenced Apr 30, 2020
Merged
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/no-base-to-string] is complaining about boolean values
4 participants
@duduluu @astorije @bradzacher @felixfbecker