Skip to content

feat(eslint-plugin): add extension rule dot-notation #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 26, 2020
Merged

feat(eslint-plugin): add extension rule dot-notation #1867

merged 11 commits into from
Apr 26, 2020

Conversation

anikethsaha
Copy link
Contributor

added new extended rule dot-notation

  • added new options
          allowPrivateClassPropertyAccess: {
            tyoe: 'boolean',
            default: true,
          },
  • tests
  • docs
  • typing update

Refer #789, #789 (comment)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @anikethsaha!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited
Loading

Codecov Report

Merging #1867 into master will decrease coverage by 0.00%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -0.01%     
==========================================
  Files         167      168       +1     
  Lines        7629     7644      +15     
  Branches     2192     2195       +3     
==========================================
+ Hits         7200     7214      +14     
  Misses        183      183              
- Partials      246      247       +1
Flag Coverage Δ
#unittest 94.37% <93.33%> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/dot-notation.ts 93.33% <93.33%> (ø)

@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Apr 8, 2020
@anikethsaha
Copy link
Contributor Author

I do think here also, the coverage might because of the optional chains

@anikethsaha anikethsaha requested a review from bradzacher April 11, 2020 06:14
@bradzacher bradzacher changed the title feat(eslint-plugin): dot-notation feat(eslint-plugin): add extension rule dot-notation Apr 20, 2020
bradzacher
bradzacher requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments around the docs, otherwise lgtm.
thanks

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 20, 2020
bradzacher
bradzacher previously approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 20, 2020
bradzacher
bradzacher previously approved these changes Apr 20, 2020
View reviewed changes
@anikethsaha
Copy link
Contributor Author

thanks a lot for quick reviews and all those helping changes.
those are always helpful 👍

@bradzacher bradzacher merged commit a85c3e1 into typescript-eslint:master Apr 26, 2020
@anikethsaha anikethsaha deleted the feat-dot-notation branch April 26, 2020 19:41
@CatsMiaow CatsMiaow mentioned this pull request Apr 28, 2020
Closed
This was referenced Apr 30, 2020
Merged
Merged
@rwaskiewicz rwaskiewicz mentioned this pull request May 5, 2020
Merged
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anikethsaha @bradzacher