-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): [member-ordering] add decorators support #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [member-ordering] add decorators support #1870
Conversation
Thanks for the PR, @miluoshi! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1870 +/- ##
==========================================
- Coverage 94.36% 94.36% -0.01%
==========================================
Files 168 168
Lines 7651 7664 +13
Branches 2199 2204 +5
==========================================
+ Hits 7220 7232 +12
Misses 183 183
- Partials 248 249 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks for this!
please fix up the merge conflict and we can merge this
Done. Thanks for the review! |
@miluoshi - FYI your merge introduced formatting errors |
@bradzacher Yes, I've noticed it and fixed it with the last commit, but I'm not sure why the Code style check still fails. I ran the format-check script locally and it passed. |
Fixes #1863
This PR adds support for grouping decorated fields and methods separately, optionally specifying their accessibility. See updated docs for details.
I'm happy to answer any questions or discuss concerns.