Skip to content

docs(eslint-plugin): fix rule URLs still point to the old repository #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2019
Merged

docs(eslint-plugin): fix rule URLs still point to the old repository #189

merged 2 commits into from
Feb 3, 2019

Conversation

lukyth
Copy link
Contributor

@lukyth lukyth commented Feb 2, 2019 •
edited
Loading

Update the URL from https://github.com/bradzacher/@typescript-eslint/eslint-plugin/blob/master/docs/rules to https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules.

Fix #188

@ficristo
Copy link

ficristo commented Feb 2, 2019

Thank you. Could you add a link also for @typescript-eslint/no-unnecessary-type-assertion ?

j-f1
j-f1 previously approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once that reference is added.

@lukyth
Copy link
Contributor Author

lukyth commented Feb 3, 2019

@ficristo @j-f1 Done :) Sorry I didn't notice that before.

@j-f1 j-f1 merged commit 3b0fed6 into typescript-eslint:master Feb 3, 2019
@j-f1
Copy link
Contributor

j-f1 commented Feb 3, 2019

Thanks for contributing!

@ficristo ficristo mentioned this pull request Feb 3, 2019
Merged
@lukyth lukyth deleted the lukyth/fix-docs-link branch February 3, 2019 13:18
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
@armano2 @JamesHenry
Migrate typescript-eslint-parser to 21.0.2 (typescript-eslint#174)
a58846c 
fixes: typescript-eslint#152, typescript-eslint#155, typescript-eslint#126, typescript-eslint#164, typescript-eslint#166, typescript-eslint#171, typescript-eslint#193, typescript-eslint#189, typescript-eslint#143, typescript-eslint#33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The links in ROADMAP file point to wrong repository
4 participants
@lukyth @ficristo @j-f1 @armano2