test(ts-estree): add test for parsing nested jsx tag names #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 95.78% 95.82% +0.03%
==========================================
Files 51 51
Lines 2541 2541
Branches 373 373
==========================================
+ Hits 2434 2435 +1
Misses 63 63
+ Partials 44 43 -1
|
|
PR with fix for this is going to land after #156 -> armano2@01d9170 |
JamesHenry
approved these changes
Feb 3, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
…lint#191) Again... lots of lines due to style formatting. Real change is: ```json "lint-staged": { "*.js": [ "yarn format", "git add" ] } ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<a.b.c.d.e.f>is not correctly parsed, this is test scenario to be fixedonly first 3 namespaces are correctly converted due to https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/src/convert.ts#L1597