-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): [restrict-template-expressions] improve error message #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [restrict-template-expressions] improve error message #1926
Conversation
Thanks for the PR, @ulrichb! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
…(add invalid type) * Also refactor (`isInnerUnionOrIntersectionConformingTo()`) and improve its name. * Also add `TWithNoConstraint` test case.
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
==========================================
- Coverage 93.93% 93.93% -0.01%
==========================================
Files 172 172
Lines 7829 7828 -1
Branches 2245 2245
==========================================
- Hits 7354 7353 -1
Misses 217 217
Partials 258 258
|
bd90c8b
to
e49b80f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this!
@bradzacher: Thanks for your review and merging! |
This makes it easier to understand the error especially when type inference is involved.
Also refactor (
isInnerUnionOrIntersectionConformingTo()
) and improve its name by making it more specific (the previous "UnderlyingExpressionType" wasn't really clear).