feat(eslint-plugin): [prefer-optional-chain] added option to convert to suggestion fixer #1965
Conversation
|
Thanks for the PR, @tianxinx99! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
=======================================
Coverage 93.88% 93.89%
=======================================
Files 170 170
Lines 7737 7744 +7
Branches 2227 2229 +2
=======================================
+ Hits 7264 7271 +7
Misses 218 218
Partials 255 255
|
There was a problem hiding this comment.
LGTM - thanks for adding this.
As an FYI, I made the following changes (I wanted to merge this now so I made them instead of going through a request change cycle):
- fixed schema
- you had the wrong property name
- you werne't using
additionalProperties: false, so the validator didn't detect it.
- use
output: nullinstead of copy pasting the text- saves the duplication and does the same check
Fixes #1820
Added the option
suggestInsteadOfAutofixwhich converts the rule into a suggestion fixer when set totrue.