Skip to content

fix(eslint-plugin): no-base-to-string boolean expression detect #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2020
Merged

fix(eslint-plugin): no-base-to-string boolean expression detect #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
935ab35
docs(eslint-plugin): typofix for no-base-to-string option
duduluu May 3, 2020
5679f00
fix(eslint-plugin): no-base-to-string boolean expression detect
duduluu May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-plugin/docs/rules/no-base-to-string.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ const defaultOptions: Options = {
};
```

### `ignoreTypeNames`
### `ignoredTypeNames`

A string array of type names to ignore, this is useful for types missing `toString()` (but actually has `toString()`).
There are some types missing `toString()` in old version TypeScript, like `RegExp`, `URL`, `URLSearchParams` etc.

The following patterns are considered correct with the default options `{ ignoreTypeNames: ["RegExp"] }`:
The following patterns are considered correct with the default options `{ ignoredTypeNames: ["RegExp"] }`:

```ts
`${/regex/}`;
Expand Down
5 changes: 4 additions & 1 deletion packages/eslint-plugin/src/rules/no-base-to-string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ export default util.createRule<Options, MessageIds>({
}

// Patch for old version TypeScript, the Boolean type definition missing toString()
if (type.flags & ts.TypeFlags.BooleanLiteral) {
if (
type.flags & ts.TypeFlags.Boolean ||
type.flags & ts.TypeFlags.BooleanLiteral
) {
return Usefulness.Always;
}

Expand Down
1 change: 1 addition & 0 deletions packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const literalListBasic: string[] = [
];

const literalListNeedParen: string[] = [
"__dirname === 'foobar'",
'{}.constructor()',
'() => {}',
'function() {}',
Expand Down