v3.0.0 breaking changes #1998

bradzacher · 2020-05-10T04:20:15Z

BREAKING CHANGE:

This is just a PR to increase visibility of breaking changes that are will be merged for the upcoming 3.0.0 release.

We will rebase merge this PR into master to preserve the history.

These changes are available on NPM under the rc-v3 tag

Release notes:
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0-alpha.23

codecov · 2020-05-10T04:29:09Z

Codecov Report

Merging #1998 into master will decrease coverage by 0.04%.
The diff coverage is 79.60%.

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
- Coverage   93.68%   93.63%   -0.05%     
==========================================
  Files         172      171       -1     
  Lines        7871     7717     -154     
  Branches     2263     2200      -63     
==========================================
- Hits         7374     7226     -148     
+ Misses        233      230       -3     
+ Partials      264      261       -3

Flag	Coverage Δ
#unittest	`93.63% <79.60%> (-0.05%)`	⬇️

Impacted Files	Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts	`88.88% <ø> (ø)`
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/comma-spacing.ts	`97.77% <ø> (ø)`
...int-plugin/src/rules/consistent-type-assertions.ts	`86.48% <ø> (ø)`
...-plugin/src/rules/explicit-function-return-type.ts	`100.00% <ø> (ø)`
...plugin/src/rules/explicit-module-boundary-types.ts	`82.60% <ø> (ø)`
...kages/eslint-plugin/src/rules/func-call-spacing.ts	`96.87% <ø> (ø)`
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts	`100.00% <ø> (ø)`
.../eslint-plugin/src/rules/member-delimiter-style.ts	`94.44% <ø> (ø)`
...kages/eslint-plugin/src/rules/naming-convention.ts	`88.51% <ø> (ø)`
... and 67 more

Bnaya · 2020-05-15T06:27:03Z

Need to update peer dependencies semver range:
Peer dependency warning:
warning " > @typescript-eslint/eslint-plugin@3.0.0-alpha.23" has incorrect peer dependency "@typescript-eslint/parser@^2.0.0".

Thanks :)

BREAKING CHANGE

…RHS` (#1163)

…less nodes (#1289)

…efault (#2003)

…ue` by default (#2005)

…sh is compared to `null`/`undefined` (#1659)

…dicates` and always check it (#1579)

…lable` to `allowNullish` (#2006)

SourceCode.isSpaceBetween only exists in 6.7.0, so isSpaceBetweenTokens is a valid alternative until older versions are dead.

…n] remove unsafe fixers These fixers are very unsafe and even providing default options for them are a bad idea. This ensures that they are suggestion fixers in all cases, and removes the options that allow them not to be.

This just creates a clearer entrypoint for contributors, and helps clearly define exactly what is exported from the modules.

bradzacher added the breaking change This change will require a new major version to be released label May 10, 2020

typescript-eslint deleted a comment from typescript-eslint bot May 11, 2020

bradzacher force-pushed the v3 branch 2 times, most recently from a8b8a6c to c1c6766 Compare May 14, 2020 08:28

bradzacher force-pushed the v3 branch from 00e641f to 79b0993 Compare May 17, 2020 23:09

bradzacher mentioned this pull request May 19, 2020

Incorrect documentation: "yarn add -D eslint ..." installs unsupported version 7.0.0 #2046

Closed

OliverSieweke and others added 19 commits May 21, 2020 09:27

feat(eslint-plugin): eslint-recommended: disable no-obj-calls (#1000)

b9ca14c

BREAKING CHANGE

feat(eslint-plugin): eslint-recommended: disable no-func-assign (#984)

ae9b8a9

BREAKING CHANGE

feat(eslint-plugin): [ban-types] rework default options (#848)

8e31d5d

feat(eslint-plugin): [no-unnecessary-condition] remove option `ignore…

ee8dd8f

…RHS` (#1163)

fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-…

82e7163

…less nodes (#1289)

feat(eslint-plugin): update eslint-recommended set (#1996)

9a96e18

feat(typescript-estree): always return parserServices (#716)

5b23443

feat: drop support for node v8 (#1997)

b6c3b7b

feat(typescript-estree): align optional fields (#1429)

0e0010f

feat(typescript-estree): align nodes with estree 2020 (#1389)

aff5b62

chore: setup automatic RC releases for v3 branch (#2000)

8a4a396

chore: trigger actions on commits into v3

02afc31

feat(eslint-plugin): [strict-boolean-expression] rework options (#1631)

cd14482

feat(eslint-plugin): update recommended sets (#2001)

0126b4f

feat(eslint-plugin): delete deprecated rules (#2002)

da0aec2

feat(eslint-plugin): [no-floating-promises] ignore void operator by d…

3626a67

…efault (#2003)

feat(eslint-plugin): [restrict-template-expressions] `allowNumber: tr…

643ec24

…ue` by default (#2005)

feat(eslint-plugin): [no-unnecessary-condition] report when non-nulli…

7fa9060

…sh is compared to `null`/`undefined` (#1659)

feat(eslint-plugin): [no-unnecessary-condition] remove `checkArrayPre…

bfd9b60

…dicates` and always check it (#1579)

bradzacher marked this pull request as ready for review May 21, 2020 16:32

bradzacher added 2 commits May 21, 2020 09:33

feat(eslint-plugin): [restrict-template-expressions] rename `allowNul…

264b017

…lable` to `allowNullish` (#2006)

feat: bump minimum required TS version (#2004)

7ad4d7c

bradzacher added 8 commits May 21, 2020 09:34

feat: upgrade to ESLint v7 (#2022)

208de71

feat(experimental-utils): upgrade eslint types for v7 (#2023)

06869c9

chore: provide more granularity in the CI logs (#2024)

a35026d

fix(typescript-estree): remove now defunct Import node type

f199cbd

fix(eslint-plugin): correct parser peerDep version

fe59f69

fix(experimental-utils): add back SourceCode.isSpaceBetweenTokens

ae82ea4

SourceCode.isSpaceBetween only exists in 6.7.0, so isSpaceBetweenTokens is a valid alternative until older versions are dead.

feat: add index files to parser and typescript-estree

3dfc46d

This just creates a clearer entrypoint for contributors, and helps clearly define exactly what is exported from the modules.

bradzacher force-pushed the v3 branch from 79b0993 to 3dfc46d Compare May 21, 2020 16:35

bradzacher merged commit 3dfc46d into master May 21, 2020

bradzacher deleted the v3 branch May 21, 2020 18:53

github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v3.0.0 breaking changes #1998

v3.0.0 breaking changes #1998

bradzacher commented May 10, 2020 •

edited

Loading

codecov bot commented May 10, 2020 •

edited

Loading

Bnaya commented May 15, 2020

v3.0.0 breaking changes #1998

v3.0.0 breaking changes #1998

Conversation

bradzacher commented May 10, 2020 • edited Loading

codecov bot commented May 10, 2020 • edited Loading

Codecov Report

Bnaya commented May 15, 2020

bradzacher commented May 10, 2020 •

edited

Loading

codecov bot commented May 10, 2020 •

edited

Loading