Skip to content

v3.0.0 breaking changes #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
May 21, 2020
Merged

v3.0.0 breaking changes #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b9ca14c
feat(eslint-plugin): eslint-recommended: disable no-obj-calls (#1000)
OliverSieweke May 9, 2020
ae9b8a9
feat(eslint-plugin): eslint-recommended: disable no-func-assign (#984)
OliverSieweke May 9, 2020
8e31d5d
feat(eslint-plugin): [ban-types] rework default options (#848)
bradzacher May 9, 2020
ee8dd8f
feat(eslint-plugin): [no-unnecessary-condition] remove option `ignore…
Retsam May 9, 2020
82e7163
fix(typescript-estree): use `TSEmptyBodyFunctionExpression` for body-…
G-Rath May 10, 2020
9a96e18
feat(eslint-plugin): update `eslint-recommended` set (#1996)
bradzacher May 10, 2020
5b23443
feat(typescript-estree): always return parserServices (#716)
bradzacher May 10, 2020
b6c3b7b
feat: drop support for node v8 (#1997)
bradzacher May 10, 2020
0e0010f
feat(typescript-estree): align optional fields (#1429)
armano2 May 10, 2020
aff5b62
feat(typescript-estree): align nodes with estree 2020 (#1389)
armano2 May 10, 2020
8a4a396
chore: setup automatic RC releases for v3 branch (#2000)
bradzacher May 10, 2020
02afc31
chore: trigger actions on commits into v3
bradzacher May 10, 2020
cd14482
feat(eslint-plugin): [strict-boolean-expression] rework options (#1631)
phaux May 10, 2020
0126b4f
feat(eslint-plugin): update recommended sets (#2001)
bradzacher May 10, 2020
da0aec2
feat(eslint-plugin): delete deprecated rules (#2002)
bradzacher May 10, 2020
3626a67
feat(eslint-plugin): [no-floating-promises] ignore void operator by d…
bradzacher May 10, 2020
643ec24
feat(eslint-plugin): [restrict-template-expressions] `allowNumber: tr…
bradzacher May 10, 2020
7fa9060
feat(eslint-plugin): [no-unnecessary-condition] report when non-nulli…
Retsam May 11, 2020
bfd9b60
feat(eslint-plugin): [no-unnecessary-condition] remove `checkArrayPre…
Retsam May 11, 2020
264b017
feat(eslint-plugin): [restrict-template-expressions] rename `allowNul…
bradzacher May 11, 2020
7ad4d7c
feat: bump minimum required TS version (#2004)
bradzacher May 11, 2020
208de71
feat: upgrade to ESLint v7 (#2022)
bradzacher May 14, 2020
06869c9
feat(experimental-utils): upgrade eslint types for v7 (#2023)
bradzacher May 14, 2020
a35026d
chore: provide more granularity in the CI logs (#2024)
bradzacher May 14, 2020
f199cbd
fix(typescript-estree): remove now defunct `Import` node type
bradzacher May 15, 2020
fe59f69
fix(eslint-plugin): correct parser peerDep version
bradzacher May 15, 2020
ae82ea4
fix(experimental-utils): add back SourceCode.isSpaceBetweenTokens
bradzacher May 17, 2020
52b6085
feat(eslint-plugin): [prefer-nullish-coalescing][prefer-optional-chai…
bradzacher May 17, 2020
3dfc46d
feat: add index files to parser and typescript-estree
bradzacher May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"ASTs",
"autofix",
"autofixers",
"autofixes",
"backticks",
"bigint",
"bivariant",
Expand Down Expand Up @@ -70,6 +71,7 @@
"performant",
"pluggable",
"postprocess",
"postprocessor",
"Premade",
"prettier's",
"recurse",
Expand All @@ -80,6 +82,7 @@
"rulesets",
"superset",
"thenables",
"transpiles",
"tsconfigs",
"tsutils",
"typedef",
Expand Down
44 changes: 25 additions & 19 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,32 +14,48 @@ module.exports = {
},
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/eslint-recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
],
parserOptions: {
sourceType: 'module',
project: [
'./tsconfig.eslint.json',
'./tests/integration/utils/jsconfig.json',
'./packages/*/tsconfig.json',
],
tsconfigRootDir: __dirname,
warnOnUnsupportedTypeScriptVersion: false,
},
rules: {
//
// our plugin :D
//

'@typescript-eslint/consistent-type-definitions': ['error', 'interface'],
'@typescript-eslint/explicit-function-return-type': 'error',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-empty-function': [
'error',
{ allow: ['arrowFunctions'] },
],
'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-non-null-assertion': 'off',
'@typescript-eslint/no-throw-literal': 'off',
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-var-requires': 'off',
'@typescript-eslint/prefer-nullish-coalescing': 'error',
'@typescript-eslint/prefer-optional-chain': 'error',
'@typescript-eslint/unbound-method': 'off',
'@typescript-eslint/prefer-as-const': 'error',

'no-empty-function': 'off',
'@typescript-eslint/no-empty-function': [
'error',
{ allow: ['arrowFunctions'] },
],
// TODO - enable these new recommended rules
'@typescript-eslint/no-floating-promises': 'off',
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-call': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-return': 'off',
'@typescript-eslint/restrict-plus-operands': 'off',
'@typescript-eslint/restrict-template-expressions': 'off',
// TODO - enable this
'@typescript-eslint/naming-convention': 'off',

//
// Internal repo rules
Expand All @@ -53,8 +69,6 @@ module.exports = {
// eslint base
//

'comma-dangle': ['error', 'always-multiline'],
'constructor-super': 'off',
curly: ['error', 'all'],
'no-mixed-operators': 'error',
'no-console': 'error',
Expand Down Expand Up @@ -128,14 +142,6 @@ module.exports = {
// Require modules with a single export to use a default export
'import/prefer-default-export': 'off', // we want everything to be named
},
parserOptions: {
sourceType: 'module',
ecmaFeatures: {
jsx: false,
},
project: ['./tsconfig.eslint.json', './packages/*/tsconfig.json'],
tsconfigRootDir: __dirname,
},
overrides: [
// all test files
{
Expand Down
Loading